Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story ads: move the ads badges to the bottom of the page #37774

Open
powerivq opened this issue Feb 25, 2022 · 1 comment
Open

Story ads: move the ads badges to the bottom of the page #37774

powerivq opened this issue Feb 25, 2022 · 1 comment
Assignees
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: monetization WG: stories

Comments

@powerivq
Copy link
Contributor

powerivq commented Feb 25, 2022

Summary

This issue proposes to move the ad badge in story to the bottom of the page.

Design Document

It's not a big change. See examples below:

After
Screen Shot 2022-02-16 at 11 28 37

Before
Screen Shot 2022-02-16 at 11 30 03

Motivation

The top of the story page is unusually cluttered. The progress bar and the open source player's action buttons are placed on top. Currently, the ad badge overlaps with these buttons, making it very difficult to see. Therefore, we are rethinking holistically where the badge should be placed, and came up with this new design.

Alternative Solutions

If we are not in favor, we may keep the existing design.

Launch Tracker

No response

Notifications

/cc @ampproject/wg-approvers @ampproject/wg-stories

@powerivq powerivq added INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: stories labels Feb 25, 2022
@powerivq powerivq self-assigned this Feb 25, 2022
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: monetization WG: stories
Projects
None yet
Development

No branches or pull requests

2 participants