Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate nomodule in Bento #37627

Open
dmanek opened this issue Feb 9, 2022 · 2 comments
Open

Deprecate nomodule in Bento #37627

dmanek opened this issue Feb 9, 2022 · 2 comments
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. Stale Inactive for one year or more

Comments

@dmanek
Copy link
Contributor

dmanek commented Feb 9, 2022

Summary

Currently we publish module and nomodule versions of Bento runtime as well as components. Modern browsers have supported JavaScript modules for some time now. See https://caniuse.com/es6-module. We should decide a date for this deprecation after which we should stop publishing nomodule versions.

Motivation

Deprecating this will reduce effort to publish nomodule versions of Bento runtime and components.

Impact on Existing Users

Users (i.e. page authors) can continue using the module versions which are well supported across modern browsers.

Alternative Implementation

Use the module versions of the Bento runtime and components.

Additional Context

No response

Notifications

/cc @ampproject/wg-approvers

@dmanek dmanek added the INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. label Feb 9, 2022
@dmanek
Copy link
Contributor Author

dmanek commented Feb 9, 2022

cc @jridgewell @alanorozco

@stale
Copy link

stale bot commented Mar 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. Stale Inactive for one year or more
Projects
None yet
Development

No branches or pull requests

1 participant