Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-vimeo] New Vimeo 'h' parameter gets encoded #37618

Open
cahirodoherty-learningpool opened this issue Feb 9, 2022 · 1 comment · May be fixed by #37886
Open

[amp-vimeo] New Vimeo 'h' parameter gets encoded #37618

cahirodoherty-learningpool opened this issue Feb 9, 2022 · 1 comment · May be fixed by #37886

Comments

@cahirodoherty-learningpool

Description

Vimeo have added a new parameter to their embed code which is required for video identification. When this is passed to the amp-video element as part of the data-videoid it gets encoded.
e.g. html containing <amp-vimeo data-videoid="https://player.vimeo.com/video/XXXXXX?h=YYYYYY"></amp-vimeo>

will be rendered as <iframe src="https://player.vimeo.com/video/XXXXXX%3Fh%3DYYYYYY"></iframe>

which is not recognised as a correct url

Reproduction Steps

Create a new Vimeo video (must be new, as only new videos add the h param)
Copy the video id from the embed code (including the h param part)
Use this video id as the data-videoid for an amp-vimeo component
Video will not render due to encoding

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

@stale
Copy link

stale bot commented Mar 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Mar 19, 2023
@stale stale bot removed the Stale Inactive for one year or more label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Todo
3 participants