Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfills Throwing Uncaught Exceptions in Safari 11.1 #35632

Open
philn5d-ar opened this issue Aug 11, 2021 · 5 comments
Open

Polyfills Throwing Uncaught Exceptions in Safari 11.1 #35632

philn5d-ar opened this issue Aug 11, 2021 · 5 comments

Comments

@philn5d-ar
Copy link

Description

2 Polyfills seem to be the cause of thousands of uncaught exceptions. These end up swamping our logs making it difficult to track other problems.

  1. TypeError: setTimeout is not a function position-observer.js:116
  2. TypeError: undefined is not an object (evaluating 'Math.round') intersection-observer.install.js:786

Both are quite shocking but also both point to ampproject source. As a publisher, we do not have control over the ad content and technology. Not sure which ad vendor is the culprit either.

Screenshot below.

image

links to sources:

https://raw.githubusercontent.com/ampproject/amphtml/2107240354000/ads/inabox/position-observer.js
https://cdn.ampproject.org/rtv/012107240354000/v0/amp-intersection-observer-polyfill-0.1.mjs

New Relic breakdown of errors chiefly related to this by platform (30 minute window):

image

Reproduction Steps

go to https://www.accuradio.com from Safari 11.1
open console
click a channel image to play and launch banner
wait for errors, if no errors yet click genres in left nav to cycle ads (15 second lockout per cycle)

Relevant Logs

No response

Browser(s) Affected

Safari

OS(s) Affected

Mac High Sierra but others as well.

Device(s) Affected

No response

AMP Version Affected

2107240354000

@kristoferbaxter
Copy link
Contributor

Adding @jridgewell and @powerivq to the issue.

Marked as P1 for triage, but this might be higher priority.

@powerivq
Copy link
Contributor

Unable to reproduce the problem on the page on a newer Safari.

@kristoferbaxter Is Safari 11 still a browser AMP maintained support?

@samouri
Copy link
Member

samouri commented Aug 12, 2021

@powerivq: we support "works but not perfect" support down to 8.0: https://amp.dev/support/faq/supported-browsers/

@jridgewell
Copy link
Contributor

When going to the site, I just get an access denied:

20210813_20_42_22_safari_11

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants