-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate non-inclusive language from AMP's source code #33694
Comments
amphtml/ads/vendors/adocean.js Lines 199 to 216 in 730e285
amphtml/examples/amp-ad/ads.amp.esm.html Line 561 in 730e285
amphtml/ads/vendors/adocean.md Line 35 in 730e285
/cc @ampproject/wg-monetization |
Lines 233 to 282 in 730e285
amphtml/test/unit/ads/test-pubmine.js Lines 63 to 75 in 730e285
/cc @ampproject/wg-monetization @ampproject/wg-components |
Validator documentation that references ownership by a
amphtml/validator/cpp/engine/validator_test.cc Line 1097 in 730e285
/cc @ampproject/wg-caching (I recognize that these might be direct references to internal code, but mentioning here in case it makes sense to use the term "Parser" or something similar.) |
AMP conformance rules that use the amphtml/build-system/test-configs/conformance-config.textproto Lines 12 to 18 in 4ef7e65
/cc @ampproject/wg-infra (Closure compiler recently added support for |
Use of the term
amphtml/third_party/vega/vega.js Lines 1 to 10 in 4ef7e65
/cc @ampproject/wg-components (We can fix our docs, but not sure if we can do anything about the 3p code.) |
As a best effort solution, we can notify the original contributors for the 3P code via GH and ask them to make the required changes. |
@micajuine-ho A newer version of the EDIT: Likely a breaking version, since we use |
Same for adocean code. We can notify them. |
It uses the htmlparser now anyhow so those comments were out of date. Updated to reflect |
@rsimha - would it be helpful to update this with the remaining files? I think most (maybe all) are resolved now. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
In the interest of making AMP development more meaningful and inclusive, we are in the midst of an effort to rectify parts of our infrastructure and source code that use non-inclusive language. See #32195 for more info.
This issue is being filed as a catch-all. I will follow up with a few comments, one per major instance I can find. If you're reading this and find a spot that I missed, please add a new comment!
The plan is to tag the WGs who own this code so they can drive fixes (where needed) at leisure. Please add a thumbs-up reaction to individual comments as acknowledgement, and back-link any fixes to this issue.
We can close this issue when all instances have been accounted for.
The text was updated successfully, but these errors were encountered: