-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I2I: Trinity Audio Player extension #33558
Comments
Thanks for your I2I. The design doc could improve by adding details about implementation: how it changes the document, what it loads, etc. cc @micajuine-ho for analytics API. |
Thanks for the quick feedback! |
@alanorozco we've updated the design doc. Let me know if we can improve it a bit more. |
@mandelbroo I've reviewed your doc. A few questions:
|
If we already have a similar signal, like |
|
@micajuine-ho thanks for the review!
It will be dispatched from an iframe and re-dispatched by the extension so it is accessible by the analytics component.
While it’s not common, we do have several publishers with multiple players per page. We need to enable the same for AMP.
The component will trigger multiple events under the same event name with different payloads, both on user interaction, as well as progress and other internal events that the publishers would like to monitor. It's made for more convenient listening for events as well as matches how the publisher listens to these events in the web component
Sure. We can rename it to amp-trinity-tts-event.
This is additional data that some events carry, adding additional context. Depending on the event type, e.g. playerReady, click, scrubbing, contentStarted, etc. They are defined by the extension (by the player). And we would like to be able to change/extend them without updating the extension. |
Not exactly sure what do you mean by “simply a URL”. You can review the flow in our draft PR https://github.com/TrinityAudioSDK/amphtml/pull/1
Yes, we saw your comment and removed these scripts from the page. |
Would these variables be similar to the video analytics variables we expose? https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/amp-video-analytics.md#common-variables |
No, I can see only a match with |
Sorry I meant similar in the sense that they are exposed by the element itself. I guess the answer here is yes. |
Summary
Trinity Audio proposes a component to enable publishers to audiofy their content using our cloud-hosted audio player.
To use the component, it is required to have an account with Trinity Audio. Registration is through our site (https://trinityaudio.ai/)
Design document
https://docs.google.com/document/d/1TAGQQiWfP1eMDQQTKfngddghLX4b7kQkSBtbRf2RYR4/edit?usp=sharing
Motivation
Trinity Audio allows textual content creators the option to distribute and interact with their readers using audio.
By doing so, it allows users to enjoy the high quality content they are already consuming in times when they couldn't before. As many of our publishers use AMP for their mobile content, creating an AMP component will allow them easy integration.
Using a native AMP component enables the component to trigger Analytics events so that publishers can track user interactions with the player. These events can then be collected by an
amp-analytics
component which sends it to the publisher’s analytics platform of choice.The text was updated successfully, but these errors were encountered: