Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-auto-ads] ad resize is failing #31301

Open
gurodrigues opened this issue Nov 23, 2020 · 3 comments
Open

[amp-auto-ads] ad resize is failing #31301

gurodrigues opened this issue Nov 23, 2020 · 3 comments
Assignees

Comments

@gurodrigues
Copy link
Contributor

What's the issue?

amp-auto-ads is not able to resize ads and it's breaking the page when it happens

How do we reproduce the issue?

The error happens most of the time, but not always. In my tests I found out that the i-amphtml-layout-awaiting-size class is breaking the ads because of it's CSS.

URL: https://sample.denakop.com/featured/top-fashion-trends-to-look-for-in-every-important-collection/?amp
amp-auto-ads config object: http://jsoneditoronline.org/#left=cloud.a2b84922eb2745f48bc2683afc15ede1
Screenshot: https://imgur.com/a/clN7JYB

What browsers are affected?

All browsers and devices

Which AMP version is affected?

Version: 2011070101001 (current version)

@caroqliu
Copy link
Contributor

cc @ampproject/wg-monetization

@powerivq powerivq self-assigned this Nov 25, 2020
@gurodrigues
Copy link
Contributor Author

@powerivq I was debugging a little more and found that even with fixed size ads this error was happening.

Removing the i-amphtml-layout-awaiting-size class from the amp-ad element would solve the problem in all scenarios that I tested.

'class': 'i-amphtml-layout-awaiting-size',

'class': 'i-amphtml-layout-awaiting-size',

I could create a PR with these changes, what do you think?

@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants