-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP-LIST AMP-SELECTOR LIMITATIONS #29834
Comments
Looks like you all are making progress on this. What do you all think the turn around time is on a patch? |
I'm not able to reproduce the behavior you're describing by trying out the first two links. I also now see that the "Nutritional Info" button in the third link downloads a PDF. I'm going to close this issue for now, but please re-open with more details if you are still having issues using any of these components. Thank you! |
I can't reopen it. Use these fiddles instead. I had to take it down off the other link. The fiddles explain in detail how to recreate the error. Not sure why you closed this out. Its a bug. The fiddles are posted above as well. Link 1: Full build out with errors being produced https://jsfiddle.net/3cge0d5a/ And by the way why did it take you all 6 months. AMP-HTML must be really buggy if it took you all that long to respond. Or you don't care. |
Hi, sorry that it took so long to get back to you. Could you also send a screenshot of what you think is being called buggy I am having the same issue with reproducing as @caroqliu |
Did you go to the fiddles and follow the instructions on the fiddle? It's
all there.
…On Fri, Feb 26, 2021 at 1:50 PM Naina Raisinghani ***@***.***> wrote:
Hi, sorry that it took so long to get back to you.
Could you also send a screenshot of what you think is being called buggy I
am having the same issue with reproducing as @caroqliu
<https://github.com/caroqliu>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29834 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYUKDRJRWOHNR6ZIE2HTNTTBACNRANCNFSM4P665UBA>
.
|
What's the issue?
Seems like there is a limit to how many selectors/togglers you can have in an amp list. In the examples below I have roughly 40 buttons on the page as options and sub options. On number 36 click (chicken quesadilla -> Rice -> Roasted Corn) the data does load but only partially and then any of the the options > 36 don't select at all.
See fiddles and dev site below.
Any ideas on why this is happening. I have a couple products that a lot of sub options. This type of behavior is happening on both instances and starts on the same count number of selectors.
How do we reproduce the issue?
Link 1: Full build out with errors being produced https://jsfiddle.net/3cge0d5a/
Link 2: Bugged data from link 1 isolated and working. Including to show that its not a data issue. https://jsfiddle.net/9vkyztb3/
Link 3: Directly on website click quesadilla nutritional info link https://dev.bajafresh.com/mexican-food-menu/kids
What browsers are affected?
All
Which AMP version is affected?
https://cdn.ampproject.org/v0.js
https://cdn.ampproject.org/v0/amp-list-0.1.js
https://cdn.ampproject.org/v0/amp-selector-0.1.js
https://cdn.ampproject.org/v0/amp-mustache-0.2.js
The text was updated successfully, but these errors were encountered: