Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 'svg' as a descendant of of tag 'amp-nested-menu'. #26463

Closed
erakor opened this issue Jan 23, 2020 · 0 comments · Fixed by #26502
Closed

Allow 'svg' as a descendant of of tag 'amp-nested-menu'. #26463

erakor opened this issue Jan 23, 2020 · 0 comments · Fixed by #26502
Assignees
@wassgha
Labels
Component: SVG P3: When Possible Type: DevX issues impacting developer experience Type: Feature Request WG: components

Comments

@erakor
Copy link

erakor commented Jan 23, 2020

Currently, the documentation only provides one example of "Disallowed tag ancestor" error:

Currently, the only example is a template tag, which may not be nested under another template tag.

However, it seems that the svg tag is cannot be nested under amp-nested-menu either.
Could it be added?

If not, we should document that "The tag 'svg' may not appear as a descendant of tag 'amp-nested-menu'."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wassgha wassgha

Labels
Component: SVG P3: When Possible Type: DevX issues impacting developer experience Type: Feature Request WG: components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨amp-nested-menu: allow svg into catherinehoule/amphtml
3 participants
@erakor @wassgha @caroqliu