Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-vimeo: Add support for unlisted videos #23804

Open
westonruter opened this issue Aug 7, 2019 · 8 comments
Open

amp-vimeo: Add support for unlisted videos #23804

westonruter opened this issue Aug 7, 2019 · 8 comments

Comments

@westonruter
Copy link
Member

westonruter commented Aug 7, 2019

Describe the new feature or change to an existing feature you'd like to see

Normal Vimeo URLs look like: https://vimeo.com/172355597

But Vimeo also has the ability to create unlisted videos: https://vimeo.com/blog/post/share-unlisted-videos-with-private-links/

Such unlisted video URLs look like: https://vimeo.com/172355597/abcdef0123

However, the amp-vimeo component has no way to supply the unlisted secret key. It only has a data-videoid attribute.

Additional context

This issue was discovered as part of the AMP plugin for WordPress: ampproject/amp-wp#2986

@westonruter
Copy link
Member Author

/cc @alanorozco

@wassgha
Copy link
Contributor

wassgha commented Aug 16, 2019

Hey @westonruter , do we have a private video we can use for testing this? (or a premium vimeo account?)

@westonruter
Copy link
Member Author

I am not aware of one, unfortunately.

@wassgha
Copy link
Contributor

wassgha commented Aug 16, 2019

Would it be safe to assume that the embed iframe will expect the same format (.../id/key) or would the iframe expect the key to be passed on as a parameter? I can't seem to find any documentation about embedding private videos on the Vimeo side (and I can't do trial and error since I don't have a private video on hand)

@westonruter
Copy link
Member Author

I was also unable to find documentation on how to embed private videos.

@stale
Copy link

stale bot commented Feb 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Feb 9, 2021
@westonruter
Copy link
Member Author

This should still be done. We just need an example unlisted Vimeo video to test.

@stale stale bot removed the Stale Inactive for one year or more label Feb 9, 2021
@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants