-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-vimeo: Add support for unlisted videos #23804
Comments
/cc @alanorozco |
Hey @westonruter , do we have a private video we can use for testing this? (or a premium vimeo account?) |
I am not aware of one, unfortunately. |
Would it be safe to assume that the embed iframe will expect the same format ( |
I was also unable to find documentation on how to embed private videos. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This should still be done. We just need an example unlisted Vimeo video to test. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Describe the new feature or change to an existing feature you'd like to see
Normal Vimeo URLs look like:
https://vimeo.com/172355597
But Vimeo also has the ability to create unlisted videos: https://vimeo.com/blog/post/share-unlisted-videos-with-private-links/
Such unlisted video URLs look like:
https://vimeo.com/172355597/abcdef0123
However, the
amp-vimeo
component has no way to supply the unlisted secret key. It only has adata-videoid
attribute.Additional context
This issue was discovered as part of the AMP plugin for WordPress: ampproject/amp-wp#2986
The text was updated successfully, but these errors were encountered: