Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator says that layout="responsive" is not supported in amp-carousel when width an height are missing which is confusing #21673

Closed
sryze opened this issue Apr 2, 2019 · 2 comments
Assignees
Labels
P3: When Possible Type: Bug Validator: Type: Error Messages Issue with the quality of the error messages that the validator produces WG: caching

Comments

@sryze
Copy link
Contributor

sryze commented Apr 2, 2019

What's the issue?

The documentation for amp-carousel states that layout="responsive" is supported where carousel type is slides, but I'm getting an error when using this type of carousel:

The specified layout 'RESPONSIVE' is not supported by tag 'AMP-CAROUSEL [type=carousel]'. (see https://www.ampproject.org/docs/reference/components/amp-carousel)

How do we reproduce the issue?

<amp-carousel class="slides" type="slides" layout="responsive" controls loop>
</amp-carousel>

What browsers are affected?

Tested in Chrome, Firefox on macOS

Which AMP version is affected?

1903262220080

@sryze sryze added the Type: Bug label Apr 2, 2019
@aghassemi
Copy link
Contributor

@sryze the message it confusing, the problem is you are missing width and height
<amp-carousel class="slides" type="slides" layout="responsive" width="300" height="150" controls loop > would work.

to @honeybadgerdontcare regarding the confusing error.

@aghassemi aghassemi changed the title Validator says that layout="responsive" is not supported in amp-carousel but I'm using type="slides" where it's supported Validator says that layout="responsive" is not supported in amp-carousel when width an height are missing which is confusing Apr 2, 2019
@honeybadgerdontcare
Copy link
Contributor

We may be able to help the validator make a more informative error message with making the attribute type=slides a dispatch key for name/value/parent.

P3, will address when we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: When Possible Type: Bug Validator: Type: Error Messages Issue with the quality of the error messages that the validator produces WG: caching
Projects
None yet
Development

No branches or pull requests

5 participants