-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-image-slider: support "vertical" case #18634
Comments
Waiting on confirmation on internal channels regarding usecases here. |
Legit use-case: https://www.kqed.org/science/1934405/see-the-camp-fire-smoke-from-space?linkId=100000004081074 Still don't like the fact that it messes up the scrolling but definitely a vertical slider makes more sense here than horizontal. |
Update another use-case here which my partner are just asking for it Guessing it won't be released in the near sprint, so I've thought of a work-around with using a div to wrapper the whole amp-image-slider, and make that div do the rotation. #rotated {
transform: rotate(90deg);
} <div id="rotated">
<amp-image-slider width="300" height="200" layout="responsive">
<amp-img
src="/img/canoe_900x600_blur.jpg"
alt="A blurry image about canoeing"
layout="fill"></amp-img>
<amp-img
src="/img/canoe_900x600.jpg"
alt="An image about canoeing"
layout="fill"></amp-img>
</amp-image-slider>
</div> The main problem is the scroll gesture is still horizontal, guessing it's due to the implementation under amp-image-slider. Would also happy to hear if there is a better work-around. |
We should constrain the maximum dimensions that the image-slider can take up, to ensure that is enevr the full viewport allowing us to at least Also best way forward is to probably add an attribute on the image slider called |
Do we have a project for the next fixit yet? |
A new Image Compare block in the popular Jetpack plugin for WordPress has an option for vertical orientation which is currently blocked on AMP pages because the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This is still needed. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
No description provided.
The text was updated successfully, but these errors were encountered: