Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad related tests failure #17137

Closed
zhouyx opened this issue Jul 26, 2018 · 3 comments
Closed

Ad related tests failure #17137

zhouyx opened this issue Jul 26, 2018 · 3 comments
Assignees
@zhouyx @lannka @calebcordry
Labels
P1: High Priority

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Jul 26, 2018

Unit tests are failing locally and on travis. Blocking other PRs.

https://travis-ci.org/ampproject/amphtml/jobs/408464336
@zhouyx zhouyx mentioned this issue Jul 26, 2018
Merged
@cosmin-vi
Copy link
Contributor

Hi guys,

Do you have any update on this ?

@lannka
Copy link
Contributor

lannka commented Aug 1, 2018

#17213 fixed the issue.

@lannka lannka closed this as completed Aug 1, 2018
@cosmin-vi
Copy link
Contributor

Thank you @lannka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyx zhouyx

@lannka lannka

@calebcordry calebcordry

Labels
P1: High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zhouyx @lannka @calebcordry @cosmin-vi