-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the universal selector to set box-sizing #1497
Comments
@dvoytenko Do you expect AMP to be generally robust with respect to different box sizing? I think the easiest solution would be to add a class called |
We should be robust. But we definitely need to retest. We can either do |
Can this be closed since #1508 was merged? |
Yes. |
Please guide me with this PR: It adds box-sizing to all elements but it can be easily overriden. |
Is this restriction still in place? I don't see it at https://www.ampproject.org/docs/design/responsive/style_pages. |
The restriction was removed in #6111 |
One extremely popular way to set box-sizing is like this (e.g. in twitter bootstrap and websites such as github itself):
However, reading from the documentation:
If I understand this correctly, this means amphtml developers need to use an explicit list of all HTML5 elements they may need, e.g.:
Note: I haven't rigorously tested this but it seems to work on my site for now.
Is this what you recommend? If so, it might be useful to add a snippet like this in the documentation or to suggest developers a better alternative so that they (and me) will have an easier time migrating.
The text was updated successfully, but these errors were encountered: