Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting lots of travis errors due to changes to the test runner, unclear how to proceed #14636

Closed
bradfrizzell opened this issue Apr 16, 2018 · 1 comment
Assignees

Comments

@bradfrizzell
Copy link
Contributor

I am getting a lot of travis errors on my PR

These errors appear to maybe be related to: #14406

I have tried rerunning a couple times now, and see the same thing. Unsure how I should proceed with these errors.

@rsimha
Copy link
Contributor

rsimha commented Apr 16, 2018

@bradfrizzell Your build didn't fail due to the console errors (they're printed so test owners can clean them up, and don't fail tests). The build failed due to some tests timing out on Safari: https://travis-ci.org/ampproject/amphtml/jobs/366290414#L698-L699 Unfortunately, short of rewriting all the integration tests, the only way past this is to re-run your tests.

If you sync to master and run your tests, you'll notice that the console errors are now collapsed by default.

@rsimha rsimha closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants