New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment navigation does not persist fragment on URL #1397

Closed

cramforce opened this issue Jan 12, 2016 · 1 comment · Fixed by #1461

Assignees

Labels

Member

cramforce commented Jan 12, 2016

To repro:

Go to http://output.jsbin.com/ratevu/quiet
Click link on top
Observe that fragment is not added to URL

Maybe related bug: Sometimes clicking a fragment link jumps to the line below the target.

To repro

go to https://www.ampproject.org/docs/guides/responsive/style_pages.html
click "Disallowed styles"
observe that headline is not actually visible (jumps to content)

cramforce added the Type: Bug label

cramforce assigned dvoytenko

cramforce mentioned this issue

Click a TOC item does not add hash to URL and jumps below headline. ampproject/amp.dev#8

Closed

Member Author

cramforce commented Jan 12, 2016

Probably makes sense to look at #1398 at the same time.

cramforce mentioned this issue

Update the URL when a fragment link to that navigates the current doc is clicked #1461

Merged

cramforce closed this as completed in #1461

henel677 mentioned this issue

SwG Release 0.1.22.138 #31549

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment