Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot call method 'replace' of undefined #10227

Closed
muxin opened this issue Jul 1, 2017 · 4 comments · Fixed by #10229
Closed

TypeError: Cannot call method 'replace' of undefined #10227

muxin opened this issue Jul 1, 2017 · 4 comments · Fixed by #10229

Comments

@muxin
Copy link
Contributor

muxin commented Jul 1, 2017

Error rate is high, happening in latest canary: 1498863866481

TypeError: Cannot call method 'replace' of undefined
    at https://cdn.ampproject.org/rtv/001498863866481/v0.js:89:51
    at https://cdn.ampproject.org/rtv/001498863866481/v0.js:25:87
export function extractClientIdFromGaCookie(gaCookie) {
  return gaCookie.replace(/^(GA1|1)\.[\d-]+\./, '');
}
@muxin
Copy link
Contributor Author

muxin commented Jul 1, 2017

/cc @lannka

@muxin
Copy link
Contributor Author

muxin commented Jul 1, 2017

/cc @aghassemi, might be related to #9952

@aghassemi
Copy link
Contributor

@lannka We are either hitting the 10000 timeout which would result in an undefined for cid.get (we should return '' in the catch I believe) or somehow getExternalCid_ is returning undefined. I don't think it is related to optout, if user is opted out, we always return empty string.

@aghassemi
Copy link
Contributor

for now reverting 1% back to the version without cid but keeping optin canary until we can look into this issue (cid stuff should not have caused new errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants