From dd6fe3243a9b8d8de9860b852f9cf90f08c924fe Mon Sep 17 00:00:00 2001 From: Daniel Rozenberg Date: Wed, 31 Jul 2024 14:32:10 -0400 Subject: [PATCH] Fix dangling TODO in cut-nightly.yml (#40070) --- build-system/release-workflows/cut-nightly.js | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/build-system/release-workflows/cut-nightly.js b/build-system/release-workflows/cut-nightly.js index f00694af28b8..ab83d421ce31 100644 --- a/build-system/release-workflows/cut-nightly.js +++ b/build-system/release-workflows/cut-nightly.js @@ -57,16 +57,11 @@ async function getCommit(octokit) { for (const {sha} of commits.data) { const checkRuns = ( - await octokit.paginate( - // TODO(danielrozenberg): seems to be related to https://github.com/octokit/plugin-paginate-rest.js/issues/350 - // restore this when the types match again: await octokit.rest.checks.listForRef, - 'GET /repos/{owner}/{repo}/commits/{ref}/check-runs', - { - ...params, - ref: sha, - 'per_page': 100, - } - ) + await octokit.paginate(octokit.rest.checks.listForRef, { + ...params, + ref: sha, + 'per_page': 100, + }) ).filter( ({'external_id': id, name}) => id !== GITHUB_EXTERNAL_ID && !CHECKS_TO_SKIP.includes(name)