🏗♻️ Forbid invoking hasOwnProperty directly (#16762)

* ESLint rule to ban hasOwnProperty

* Do not forbid hasOwnProperty in validator code

* Do not forbid hasOwnProperty in build-system code

.eslintrc

@@ -69,6 +69,7 @@
     "amphtml-internal/no-export-side-effect": 2,
     "amphtml-internal/no-for-of-statement": 2,
     "amphtml-internal/no-global": 0,
+    "amphtml-internal/no-has-own-property-method": 1,
     "amphtml-internal/no-mixed-operators": 2,
     "amphtml-internal/no-spread": 2,
     "amphtml-internal/no-style-property-setting": 2,

build-system/.eslintrc

@@ -9,6 +9,7 @@
   },
   "rules": {
     "amphtml-internal/no-for-of-statement": 0,
+    "amphtml-internal/no-has-own-property-method": 0,
     "require-jsdoc": 0
   }
 }

build-system/eslint-rules/no-has-own-property-method.js

@@ -0,0 +1,33 @@
+/**
+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+'use strict';
+
+module.exports = {
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type == 'MemberExpression' && !node.callee.computed &&
+            node.callee.property.name == 'hasOwnProperty') {
+          context.report({
+            node,
+            message: 'Do not use hasOwnProperty directly. ' +
+                'Use hasOwn from src/utils/object.js instead.',
+          });
+        }
+      },
+    };
+  },
+};

validator/.eslintrc

@@ -21,6 +21,7 @@
   },
   "rules": {
     "amphtml-internal/no-for-of-statement": 0,
+    "amphtml-internal/no-has-own-property-method": 0,
     "chai-expect/missing-assertion": 1,
     "google-camelcase/google-camelcase": 0,
     "jsdoc/check-param-names": 0,