From 035071aa118c1ebd99e0ead1cc358f00d16409e9 Mon Sep 17 00:00:00 2001 From: Jake Fried Date: Thu, 3 Feb 2022 11:16:00 -0700 Subject: [PATCH] build-system: cleanup esbuild options (#37468) --- build-system/tasks/extension-helpers.js | 3 --- build-system/tasks/helpers.js | 7 +------ 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/build-system/tasks/extension-helpers.js b/build-system/tasks/extension-helpers.js index 2102db7b66e9..d0ac7c3de87f 100644 --- a/build-system/tasks/extension-helpers.js +++ b/build-system/tasks/extension-helpers.js @@ -678,9 +678,6 @@ async function maybeBuildBentoExtensionJs(dir, name, options) { const bentoName = getBentoName(name); return buildExtensionJs(dir, bentoName, { ...options, - // Use esbuild since Closure does not use a different babel config for - // Bento elements. - esbuild: true, wrapper: 'bento', babelCaller: options.minify ? 'bento-element-minified' diff --git a/build-system/tasks/helpers.js b/build-system/tasks/helpers.js index 4709542989a4..ebf0e59a5ac5 100644 --- a/build-system/tasks/helpers.js +++ b/build-system/tasks/helpers.js @@ -127,12 +127,7 @@ async function compileBentoRuntime(options) { const filename = `${srcDir}/${srcFilename}`; const fileSource = generateBentoRuntimeEntrypoint(); await fs.outputFile(filename, fileSource); - await doBuildJs(jsBundles, 'bento.js', { - ...options, - // The pre-closure babel step wants the entry file to be generated earlier. - // Much simpler to generate it here and use esbuild instead. - esbuild: true, - }); + await doBuildJs(jsBundles, 'bento.js', options); } /**