-
Notifications
You must be signed in to change notification settings - Fork 3.9k
/
Copy pathawait-expect.js
75 lines (68 loc) · 1.82 KB
/
await-expect.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
/**
* Copyright 2019 The AMP HTML Authors. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS-IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
'use strict';
/**
* Forces `expect` calls to be preceded by `await` in end-to-end tests.
*
* Bad:
* expect(actual).to.equal(expected);
* Good:
* await expect(actual).to.equal(expected);
* @return {!Object}
*/
module.exports = function (context) {
return {
CallExpression(node) {
const filename = context.getFilename();
if (!/test-e2e|\/test\/e2e\//.test(filename)) {
return;
}
const {callee} = node;
if (callee.type !== 'Identifier') {
return;
}
if (callee.name !== 'expect') {
return;
}
const comments = context.getCommentsBefore(callee);
const ok = comments.some((comment) => comment.value === 'OK');
if (ok) {
return;
}
if (hasAwaitParent(node)) {
return;
}
context.report({
node,
message: '`expect` in end-to-end tests must use `await`.',
});
},
};
};
/**
* Returns true if the given espree AST node is a child of an `AwaitExpression`.
* @param {!Object} node
* @return {boolean}
*/
function hasAwaitParent(node) {
while (node) {
if (node.type == 'AwaitExpression') {
return true;
}
node = node.parent;
}
return false;
}