Skip to content

fix: add sseclient-py to setup.py #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

fix: add sseclient-py to setup.py #63

merged 1 commit into from
Mar 13, 2025

Conversation

shaoye
Copy link
Contributor

@shaoye shaoye commented Mar 13, 2025 •
edited
Loading

fix ModuleNotFoundError: No module named 'sseclient' in 1.8.0

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@shaoye
Add sseclient-py to setup.py
07fb359 
fix `ModuleNotFoundError: No module named 'sseclient'` in 1.8.0
@shaoye shaoye mentioned this pull request Mar 13, 2025
Merged
1 task
@zhukaihan zhukaihan changed the title Add sseclient-py to setup.py fix: add sseclient-py to setup.py Mar 13, 2025
@zhukaihan
Copy link
Collaborator

zhukaihan commented Mar 13, 2025 •
edited
Loading

Test aren't passing related to not having access to keys. All other tests passed. Merging... We'll double check on our main branch.

@zhukaihan zhukaihan merged commit a52c8e8 into amplitude:main Mar 13, 2025
1 of 4 checks passed
@zhukaihan
Copy link
Collaborator

Thanks for the PR. Sorry about the inconvenience.
Test all passes and released in v1.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhukaihan zhukaihan zhukaihan approved these changes

@bgiori bgiori Awaiting requested review from bgiori

@tyiuhc tyiuhc Awaiting requested review from tyiuhc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaoye @zhukaihan