Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics-react-native): support RN 0.73 #871

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Sep 13, 2024

Summary

For RN >= 0.73

  • Added new AndroidManifestNew.xml without namespace
  • Added namespace in build.gradle

Fix

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@Mercy811 Mercy811 changed the title feat(analytics-react-native): support RN 0.73 fix(analytics-react-native): support RN 0.73 Sep 13, 2024
@Mercy811 Mercy811 marked this pull request as ready for review September 13, 2024 00:14
@grifotv
Copy link

grifotv commented Sep 13, 2024

@Mercy811 Would this PR solve this issue #695 (comment) ?

@Mercy811
Copy link
Contributor Author

Hi @grifotv, the languageVersion error is from gradle. See facebook/react-native#41580 (comment)

@Mercy811 Mercy811 merged commit d0ae4d6 into main Sep 13, 2024
5 checks passed
@Mercy811 Mercy811 deleted the AMP-93892-RN-0.73 branch September 13, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants