Skip to content

Commit 9bc28fb

Browse files
Merge pull request #95 from amitshekhariitbhu/development
Merge from Development
2 parents a31ad4e + eaedc64 commit 9bc28fb

File tree

9 files changed

+23
-29
lines changed

9 files changed

+23
-29
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,11 @@ public static void setCustomDatabaseFiles(Context context) {
103103
Class<?> debugDB = Class.forName("com.amitshekhar.DebugDB");
104104
Class[] argTypes = new Class[]{HashMap.class};
105105
Method setCustomDatabaseFiles = debugDB.getMethod("setCustomDatabaseFiles", argTypes);
106-
HashMap<String, File> customDatabaseFiles = new HashMap<>();
106+
HashMap<String, Pair<File, String>> customDatabaseFiles = new HashMap<>();
107107
// set your custom database files
108108
customDatabaseFiles.put(ExtTestDBHelper.DATABASE_NAME,
109-
new File(context.getFilesDir() + "/" + ExtTestDBHelper.DIR_NAME +
110-
"/" + ExtTestDBHelper.DATABASE_NAME));
109+
new Pair<>(new File(context.getFilesDir() + "/" + ExtTestDBHelper.DIR_NAME +
110+
"/" + ExtTestDBHelper.DATABASE_NAME), ""));
111111
setCustomDatabaseFiles.invoke(null, customDatabaseFiles);
112112
} catch (Exception ignore) {
113113

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ android {
3232
}
3333
buildTypes {
3434
debug {
35-
resValue("string", "PORT_NUMBER", "8081")
35+
resValue("string", "PORT_NUMBER", "8080")
3636
resValue("string", "DB_PASSWORD_PERSON", "a_password")
3737
}
3838
release {

app/src/main/java/com/sample/database/PersonDBHelper.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919

2020
package com.sample.database;
2121

22-
import android.app.Application;
2322
import android.content.ContentValues;
2423
import android.content.Context;
2524
import android.database.Cursor;
25+
2626
import net.sqlcipher.DatabaseUtils;
2727
import net.sqlcipher.database.SQLiteDatabase;
2828
import net.sqlcipher.database.SQLiteOpenHelper;
@@ -110,7 +110,7 @@ public ArrayList<String> getAllPerson() {
110110
while (!res.isAfterLast()) {
111111
arrayList.add(
112112
res.getString(res.getColumnIndex(PERSON_COLUMN_FIRST_NAME)) + " " +
113-
res.getString(res.getColumnIndex(PERSON_COLUMN_LAST_NAME)));
113+
res.getString(res.getColumnIndex(PERSON_COLUMN_LAST_NAME)));
114114
res.moveToNext();
115115
}
116116
res.close();
@@ -128,8 +128,7 @@ public int count() {
128128
} else {
129129
return 0;
130130
}
131-
}
132-
finally {
131+
} finally {
133132
cursor.close();
134133
db.close();
135134
}

debug-db/src/main/java/com/amitshekhar/DebugDB.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828

2929
import java.io.File;
3030
import java.util.HashMap;
31-
import java.util.Map;
3231

3332
/**
3433
* Created by amitshekhar on 15/11/16.
@@ -74,12 +73,12 @@ public static void shutDown() {
7473
}
7574
}
7675

77-
public static void setCustomDatabaseFiles(HashMap<String, Pair<File, String>> customDatabaseFiles){
78-
if(clientServer!=null){
76+
public static void setCustomDatabaseFiles(HashMap<String, Pair<File, String>> customDatabaseFiles) {
77+
if (clientServer != null) {
7978
clientServer.setCustomDatabaseFiles(customDatabaseFiles);
8079
}
8180
}
82-
81+
8382
public static boolean isServerRunning() {
8483
return clientServer != null && clientServer.isRunning();
8584
}

debug-db/src/main/java/com/amitshekhar/model/TableDataResponse.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ public static class TableInfo {
3838
public String title;
3939
public boolean isPrimary;
4040
}
41+
4142
public static class ColumnData {
4243
public String dataType;
4344
public Object value;

debug-db/src/main/java/com/amitshekhar/server/ClientServer.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import java.net.Socket;
3535
import java.net.SocketException;
3636
import java.util.HashMap;
37-
import java.util.Map;
3837

3938
public class ClientServer implements Runnable {
4039

@@ -88,8 +87,8 @@ public void run() {
8887
}
8988
}
9089

91-
public void setCustomDatabaseFiles(HashMap<String, Pair<File, String>> customDatabaseFiles){
92-
mRequestHandler.setCustomDatabaseFiles(customDatabaseFiles);
90+
public void setCustomDatabaseFiles(HashMap<String, Pair<File, String>> customDatabaseFiles) {
91+
mRequestHandler.setCustomDatabaseFiles(customDatabaseFiles);
9392
}
9493

9594
public boolean isRunning() {

debug-db/src/main/java/com/amitshekhar/server/RequestHandler.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import android.content.Context;
2323
import android.content.res.AssetManager;
24-
import net.sqlcipher.database.SQLiteDatabase;
2524
import android.net.Uri;
2625
import android.text.TextUtils;
2726
import android.util.Pair;
@@ -39,6 +38,8 @@
3938
import com.google.gson.GsonBuilder;
4039
import com.google.gson.reflect.TypeToken;
4140

41+
import net.sqlcipher.database.SQLiteDatabase;
42+
4243
import java.io.BufferedReader;
4344
import java.io.File;
4445
import java.io.IOException;
@@ -155,7 +156,7 @@ public void handle(Socket socket) throws IOException {
155156
}
156157
}
157158

158-
public void setCustomDatabaseFiles(HashMap<String, Pair<File, String>> customDatabaseFiles){
159+
public void setCustomDatabaseFiles(HashMap<String, Pair<File, String>> customDatabaseFiles) {
159160
mCustomDatabaseFiles = customDatabaseFiles;
160161
}
161162

@@ -185,17 +186,17 @@ private void closeDatabase() {
185186

186187
private String getDBListResponse() {
187188
mDatabaseFiles = DatabaseFileProvider.getDatabaseFiles(mContext);
188-
if(mCustomDatabaseFiles!=null){
189+
if (mCustomDatabaseFiles != null) {
189190
mDatabaseFiles.putAll(mCustomDatabaseFiles);
190191
}
191192
Response response = new Response();
192193
if (mDatabaseFiles != null) {
193194
for (HashMap.Entry<String, Pair<File, String>> entry : mDatabaseFiles.entrySet()) {
194-
String[] dbEntry = { entry.getKey(), entry.getValue().second != "" ? "true" : "false" };
195+
String[] dbEntry = {entry.getKey(), !entry.getValue().second.equals("") ? "true" : "false"};
195196
response.rows.add(dbEntry);
196197
}
197198
}
198-
response.rows.add(new String[] { Constants.APP_SHARED_PREFERENCES, "false" });
199+
response.rows.add(new String[]{Constants.APP_SHARED_PREFERENCES, "false"});
199200
response.isSuccessful = true;
200201
return mGson.toJson(response);
201202
}
@@ -238,7 +239,7 @@ private String executeQueryAndGetResponse(String route) {
238239
if (query != null) {
239240
String[] statements = query.split(";");
240241

241-
for (int i=0; i<statements.length; i++) {
242+
for (int i = 0; i < statements.length; i++) {
242243

243244
String aQuery = statements[i].trim();
244245
first = aQuery.split(" ")[0].toLowerCase();

debug-db/src/main/java/com/amitshekhar/utils/DatabaseFileProvider.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,11 @@
2020
package com.amitshekhar.utils;
2121

2222
import android.content.Context;
23-
import android.content.res.Resources;
2423
import android.util.Pair;
2524

26-
import com.amitshekhar.R;
27-
2825
import java.io.File;
2926
import java.text.MessageFormat;
3027
import java.util.HashMap;
31-
import java.util.List;
3228

3329
/**
3430
* Created by amitshekhar on 06/02/17.

debug-db/src/main/java/com/amitshekhar/utils/DatabaseHelper.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,16 @@
2020
package com.amitshekhar.utils;
2121

2222
import android.content.ContentValues;
23-
24-
import net.sqlcipher.Cursor;
25-
import net.sqlcipher.database.SQLiteDatabase;
2623
import android.text.TextUtils;
27-
import android.util.Log;
2824

2925
import com.amitshekhar.model.Response;
3026
import com.amitshekhar.model.RowDataRequest;
3127
import com.amitshekhar.model.TableDataResponse;
3228
import com.amitshekhar.model.UpdateRowResponse;
3329

30+
import net.sqlcipher.Cursor;
31+
import net.sqlcipher.database.SQLiteDatabase;
32+
3433
import java.util.ArrayList;
3534
import java.util.HashSet;
3635
import java.util.List;

0 commit comments

Comments
 (0)