Add views to complete the API and pass (almost) all tests

Author: amitkummer

manager/tasks/tests/test_people.py

@@ -39,8 +39,8 @@ def test_post(self):
                         data={'name':'Ido', 'email': 'ido@gmail.com', 'favoriteProgrammingLanguage': 'Python'})
         self.assertEqual(response.status_code, 201)
         id = Person.objects.filter(name='Ido').get().id
-        self.assertEqual(response.headers['Location'], f'/people/{id}')
-        self.assertEqual(response.headers['x-Created-Id'], id)
+        self.assertEqual(response.headers['Location'], f'people/{id}')
+        self.assertEqual(response.headers['x-Created-Id'], str(id))
 
     def test_post_400(self):
         response = self.client.post(reverse('person-list'), 
@@ -105,8 +105,8 @@ def test_post_tasks_nested(self):
             data={'title':'a tour of c++', 'details':'details', 'dueDate':date.today(), 'status':'active'})
         self.assertEqual(response.status_code, 201)
         id = Task.objects.filter(title='a tour of c++').get().id
-        self.assertEqual(response.headers['Location'], f'/tasks/{id}')
-        self.assertEqual(response.headers['x-Created-Id'], id)
+        self.assertEqual(response.headers['Location'], f'tasks/{id}')
+        self.assertEqual(response.headers['x-Created-Id'], str(id))
 
     def test_post_tasks_nested_400(self):
         response = self.client.post(reverse('person-tasks', args=[self.person.id]),

manager/tasks/views.py

@@ -1,4 +1,4 @@
-from django.shortcuts import render
+from functools import partial
 from rest_framework import viewsets
 from rest_framework.decorators import action
 from rest_framework.response import Response
@@ -11,16 +11,61 @@ class TaskViewSet(viewsets.ModelViewSet):
     queryset = Task.objects.all()
     serializer_class = TaskSerializer
 
+    @action(detail=True, methods=['get', 'put'])
+    def status(self, request, pk):
+        try:
+            task = Task.objects.filter(id=pk).get()
+        except Task.DoesNotExist:
+            return Response("{ id does not exist }", status=status.HTTP_404_NOT_FOUND)
+
+        if request.method == 'GET':
+            return Response(f"{{ '{task.status}' }}")
+        else:
+            serializer = TaskSerializer(task, data=request.data, partial=True)
+            if serializer.is_valid():
+                return Response(status=status.HTTP_204_NO_CONTENT)
+            else:
+                return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
+
+    @action(detail=True, methods=['get', 'put'])
+    def owner(self, request, pk):
+        try:
+            task = Task.objects.filter(id=pk).get()
+        except Task.DoesNotExist:
+            return Response("{ id does not exist }", status=status.HTTP_404_NOT_FOUND)
+        
+        if request.method == 'GET':
+            return Response(f"{{ '{task.ownerId}' }}")
+        else:
+            serializer = TaskSerializer(task, data=request.data, partial=True)
+            if serializer.is_valid():
+                return Response(status=status.HTTP_204_NO_CONTENT)
+            else:
+                return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
+    
+    def create(self, request):
+        serializer = TaskSerializer(data=request.data)
+        if serializer.is_valid():
+            task = serializer.save()
+            return Response(headers={'Location':f'tasks/{task.id}', 'x-Created-Id':task.id}, status=status.HTTP_201_CREATED)
+        else:
+            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
+
+
 class PersonViewSet(viewsets.ModelViewSet):
     queryset = Person.objects.all()
     serializer_class = PersonSerializer 
 
     @action(detail=True, methods=['get', 'post'])
     def tasks(self, request, pk):
+        try:
+            Person.objects.filter(id=pk).get()
+        except Person.DoesNotExist:
+            return Response("{ id does not exist }", status=status.HTTP_404_NOT_FOUND)
         if request.method == 'GET':
             person_tasks = Task.objects.filter(ownerId=pk)
             if person_tasks.count() < 1:
-                return Response(data="{'Tasks not found'}", status=status.HTTP_404_NOT_FOUND)
+                return Response(data="{'Tasks do not exist'}", status=status.HTTP_404_NOT_FOUND)
             serializer = TaskSerializer(person_tasks, many=True)
             return Response(serializer.data)
         else:
@@ -29,14 +74,14 @@ def tasks(self, request, pk):
             serializer = TaskSerializer(data=data)
             if serializer.is_valid():
                 task = serializer.save()
-                return Response(headers={'Location':'Raz', 'x-Created-Id':task.id}, status=status.HTTP_201_CREATED)
+                return Response(headers={'Location':f'tasks/{task.id}', 'x-Created-Id':task.id}, status=status.HTTP_201_CREATED)
             else:
                 return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
 
     def create(self, request):
         serializer = PersonSerializer(data=request.data)
         if serializer.is_valid():
             person = serializer.save()
-            return Response(headers={'Location':'Raz', 'x-Created-Id':person.id}, status=status.HTTP_201_CREATED)
+            return Response(headers={'Location':f'people/{person.id}', 'x-Created-Id':person.id}, status=status.HTTP_201_CREATED)
         else:
             return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)