Merge changes from upstream branch #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps e.g. psalm static analysis.
Update PHPDoc - don't return "Boolean" use bool or false instead
Change mentioned current Symfony version from 4 to 5
…alse on newer versions and is deprecated since PHP 7.4
Test PHP 7.3 and 7.4
Update README.md
…-fix-cve-2019-18888 Backport fix for cve-2019-18888
…ollowing-218 Fix tests count following FriendsOfSymfony1#218
…ll in sfForm.class.php on line 947`
Fix array and string offset access using curly braces (Deprecated since PHP 7.4) Fix array and string offset access using curly braces (Deprecated since PHP 7.4) PHP 7.4 incompatibility fix: Passing the glue and pieces parameters in reverse order to implode has been deprecated since PHP 7.4
…he session module's ini settings at this time`
…arning-on-php72-and-above Fix for `Warning: ini_set(): A session is active...`
- Add PHP requirements - Cleanup Travis - Update changelog
Php 7.4 Incompatibility Fixes
…notice Remove notice appeared on php 7.4
…pdate-composer Rename package to `friendsofsymfony1/symfony1`
…er-json-to-automatically-remove-lexpress-symfomy1 Update composer.json to automatically remove `lexpress/symfony1` package
…module-fix Update GIT url from lexpress to fos1 in the submodules.
…ler-6-compat-2 Add compatibility for Swiftmailer 6 and preserve compatibility with Swiftmailer 5
We can actually pass array to sfWebController::redirect() function as first parameter, but IDE wrongly highlights this as "Expected parameter of type 'string', 'array' provided".
The more precise the types are, the better IDE will help preventing errors. Co-authored-by: Ivan Voskoboinyk <ivan.voskoboinyk@gmail.com>
According to discussion: FriendsOfSymfony1#246 (comment)
Update PHPDoc for `redirect()` and `url()` functions on sfWebController
Ensure sfValidatorBoolean::clean() returns false when 0 (integer zero) is passed in (fixes FriendsOfSymfony1#234 )
Author
|
Checking with @wutsch0 if we can delete his changes and rely on changes from upstream |
Use strict comparison in `in_array()` and add boolean and usual integer values to 'true_values' and 'false_values' options
wutsch0
approved these changes
Jun 1, 2021
wutsch0
left a comment
wutsch0
left a comment
There was a problem hiding this comment.
i have not managed to find exactly why i created the fix in sfValidatorBoolean.class.php, it is probably either lyMediaAssetForm or one of the UserProfileForms.
But my fix is still necessary because the official fix doesn't fix the situation if the value is true or false, which was the original reason to create it.
We can still merge as you did, but I would be afraid to remove it since if its reappearing it either breaks editorial content or user data, both with data loss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.