Commit f8bbc07
tun: limit printing rate when illegal packet received by tun dev
vhost_worker will call tun call backs to receive packets. If too many
illegal packets arrives, tun_do_read will keep dumping packet contents.
When console is enabled, it will costs much more cpu time to dump
packet and soft lockup will be detected.
net_ratelimit mechanism can be used to limit the dumping rate.
PID: 33036 TASK: ffff949da6f20000 CPU: 23 COMMAND: "vhost-32980"
#0 [fffffe00003fce50] crash_nmi_callback at ffffffff89249253
openbmc#1 [fffffe00003fce58] nmi_handle at ffffffff89225fa3
openbmc#2 [fffffe00003fceb0] default_do_nmi at ffffffff8922642e
openbmc#3 [fffffe00003fced0] do_nmi at ffffffff8922660d
openbmc#4 [fffffe00003fcef0] end_repeat_nmi at ffffffff89c01663
[exception RIP: io_serial_in+20]
RIP: ffffffff89792594 RSP: ffffa655314979e8 RFLAGS: 00000002
RAX: ffffffff89792500 RBX: ffffffff8af428a0 RCX: 0000000000000000
RDX: 00000000000003fd RSI: 0000000000000005 RDI: ffffffff8af428a0
RBP: 0000000000002710 R8: 0000000000000004 R9: 000000000000000f
R10: 0000000000000000 R11: ffffffff8acbf64f R12: 0000000000000020
R13: ffffffff8acbf698 R14: 0000000000000058 R15: 0000000000000000
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
openbmc#5 [ffffa655314979e8] io_serial_in at ffffffff89792594
openbmc#6 [ffffa655314979e8] wait_for_xmitr at ffffffff89793470
openbmc#7 [ffffa65531497a08] serial8250_console_putchar at ffffffff897934f6
openbmc#8 [ffffa65531497a20] uart_console_write at ffffffff8978b605
openbmc#9 [ffffa65531497a48] serial8250_console_write at ffffffff89796558
openbmc#10 [ffffa65531497ac8] console_unlock at ffffffff89316124
openbmc#11 [ffffa65531497b10] vprintk_emit at ffffffff89317c07
openbmc#12 [ffffa65531497b68] printk at ffffffff89318306
openbmc#13 [ffffa65531497bc8] print_hex_dump at ffffffff89650765
openbmc#14 [ffffa65531497ca8] tun_do_read at ffffffffc0b06c27 [tun]
openbmc#15 [ffffa65531497d38] tun_recvmsg at ffffffffc0b06e34 [tun]
openbmc#16 [ffffa65531497d68] handle_rx at ffffffffc0c5d682 [vhost_net]
openbmc#17 [ffffa65531497ed0] vhost_worker at ffffffffc0c644dc [vhost]
openbmc#18 [ffffa65531497f10] kthread at ffffffff892d2e72
openbmc#19 [ffffa65531497f50] ret_from_fork at ffffffff89c0022f
Fixes: ef3db4a ("tun: avoid BUG, dump packet on GSO errors")
Signed-off-by: Lei Chen <lei.chen@smartx.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link: https://lore.kernel.org/r/20240415020247.2207781-1-lei.chen@smartx.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>1 parent e226ead commit f8bbc07
1 file changed
+10
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2125 | 2125 | | |
2126 | 2126 | | |
2127 | 2127 | | |
2128 | | - | |
2129 | | - | |
2130 | | - | |
2131 | | - | |
2132 | | - | |
2133 | | - | |
2134 | | - | |
2135 | | - | |
| 2128 | + | |
| 2129 | + | |
| 2130 | + | |
| 2131 | + | |
| 2132 | + | |
| 2133 | + | |
| 2134 | + | |
| 2135 | + | |
| 2136 | + | |
| 2137 | + | |
2136 | 2138 | | |
2137 | 2139 | | |
2138 | 2140 | | |
| |||
0 commit comments