Fix CI pipeline for old Bash versions and add macOS support. (#701)

* feat: add macOS CI testing workflow

* fix: std text replace not failing

* fix: make replace compatible with bash 4.2

* fix: base_base_image -> base_bash_image

* doc: minor styling

* fix: replace function

* fix: regex basic test

* fix: array_extract_at test

* fix: date posix test

Author: Ph0enixKM

.github/workflows/rust.yml

@@ -129,6 +129,23 @@ jobs:
           cargo test --all-targets --all-features
           docker stop test_container -t 0
           docker rm --force test_container
+  macos-test:
+    name: Rust tests on a native macOS Bash
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - name: Cache dependencies installed with cargo
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.cargo
+            ./target/deps
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: ${{ runner.os }}-cargo-
+      - name: Run tests
+        run: |
+          cargo test --all-targets --all-features
   clippy:
     name: Clippy tests
     runs-on: ubuntu-latest

src/std/array.ab

@@ -49,10 +49,10 @@ pub fun array_remove_at(ref array: [], index: Num): Null {
     array = array[0..index] + array[offset..length]
 }
 
-/// Removes an element at the index from the array, and returns it; if the
-/// index is negative or beyond the end, the return value is undefined, but
-/// the array will be unchanged.
+/// Removes an element at the index from the array, and returns it
 pub fun array_extract_at(ref array, index) {
+    if index < 0 or index >= len(array):
+        fail 1
     let element = array[index]
     let offset = index + 1
     let length = len(array)

src/std/date.ab

@@ -1,5 +1,7 @@
+import { char_at, slice } from "std/text"
+
 /// ### EXPERIMENTAL
-/// 
+///
 /// Formats a date with a special format.
 ///
 /// If no date is specified, the current date is used.
@@ -8,7 +10,7 @@
 ///
 /// For more info about format type "man date" on your shell or go to <https://www.gnu.org/software/coreutils/date>.
 ///
-/// Format : 
+/// Format :
 /// ```
 /// %%     a literal %
 /// %a     locale's abbreviated weekday name (e.g., Sun)
@@ -57,7 +59,7 @@
 /// %:::z  numeric time zone with : to necessary precision (e.g., -04, +05:30)
 /// %Z     alphabetic time zone abbreviation (e.g., EDT)
 /// ```
-/// 
+///
 /// By default, date pads numeric fields with zeroes.  The following optional flags may follow '%':
 ///
 /// ```
@@ -71,11 +73,17 @@
 pub fun date_posix(format: Text = "", date: Text = "", utc: Bool = false): Text? {
     if format == "": format = "%FT%T%Z"
     if date == "": date = trust $ date +"%FT%T%Z" $
-    if (utc) {
-        return $ date --utc -d "{date}" +"{format}" $?
-    } else {
-        return $ date -d "{date}" +"{format}" $?
-    }    
+    let utc_flag = utc then "-u" else ""
+    // Case if this is a GNU date command
+    return $ date {utc_flag} -d "{date}" +"{format}" $ failed {
+        // Case if this is a BSD date command
+        if char_at(date, 0) == "@" {
+            // If the date is a timestamp, we need to convert it to a date string first
+            let timestamp = slice(date, 1)
+            return $ date {utc_flag} -r "{timestamp}" +"{format}" $?
+        }
+        fail 1
+    }
 }
 
 /// Returns the current timestamp (seconds since the Epoch (1970-01-01 00:00 UTC)).
@@ -87,12 +95,12 @@ pub fun date_now(): Num {
 /// ### EXPERIMENTAL
 ///
 /// Adds a value to a date.
-/// 
+///
 /// If no date is specified, the current date is used.
-/// 
+///
 /// Example : `date_add("+3 days")`
-/// 
-/// You can use (+/-): 
+///
+/// You can use (+/-):
 ///
 /// - years
 /// - months
@@ -111,7 +119,7 @@ pub fun date_add(add:Text, date:Text = "", utc: Bool = false): Text? {
 /// Returns 1 if date_a is after date_b.
 ///
 /// Returns 0 if date_a and date_b is the same.
-/// 
+///
 /// Returns -1 if date_b is after date_a.
 ///
 /// If date_b is not provided, current date will be used.

src/std/text.ab

@@ -1,16 +1,34 @@
+// We cannot import `bash_version` from `env.ab` because it imports `text.ab` making a circular dependency.
+// This is a workaround to avoid that issue and the import system should be improved in the future.
+#[allow_absurd_cast]
+fun bash_version(): [Num] {
+    let major = trust $ echo "\$\{BASH_VERSINFO[0]}" $ as Num
+    let minor = trust $ echo "\$\{BASH_VERSINFO[1]}" $ as Num
+    let patch = trust $ echo "\$\{BASH_VERSINFO[2]}" $ as Num
+    return [major, minor, patch]
+}
+
 /// Replaces all occurrences of a pattern in the content with the provided replace text.
 pub fun replace(source, search, replace) {
-    // Here we use a command to avoid GH-646
+    // Here we use a command to avoid #646
     let result = ""
-    trust $ {nameof result}="\$\{{nameof source}//\"\$\{{nameof search}}\"/\"\$\{{nameof replace}}\"}" $
+    if bash_version() > [4,2] {
+        trust $ {nameof result}="\$\{{nameof source}//\"\$\{{nameof search}}\"/\"\$\{{nameof replace}}\"}" $
+    } else {
+        trust $ {nameof result}="\$\{{nameof source}//\"\$\{{nameof search}}\"/\$\{{nameof replace}}}" $
+    }
     return result
 }
 
 /// Replaces the first occurrence of a pattern in the content with the provided replace text.
 pub fun replace_one(source, search, replace) {
-    // Here we use a command to avoid GH-646
+    // Here we use a command to avoid #646
     let result = ""
-    trust $ {nameof result}="\$\{{nameof source}/\"\$\{{nameof search}}\"/\"\$\{{nameof replace}}\"}" $
+    if bash_version() > [4,2] {
+        trust $ {nameof result}="\$\{{nameof source}/\"\$\{{nameof search}}\"/\"\$\{{nameof replace}}\"}" $
+    } else {
+        trust $ {nameof result}="\$\{{nameof source}/\"\$\{{nameof search}}\"/\$\{{nameof replace}}}" $
+    }
     return result
 }
 

src/tests/mod.rs

@@ -34,6 +34,7 @@ pub fn test_amber(code: &str, result: &str, target: TestOutcomeTarget) {
         TestOutcomeTarget::Success => match evaluated {
             Ok(stdout) => {
                 let stdout = stdout.trim_end_matches('\n');
+                dbg!(stdout);
                 if stdout != SUCCEEDED {
                     let result = result.trim_end_matches('\n');
                     assert_eq!(stdout, result)

src/tests/stdlib/array_extract_at.ab

@@ -1,25 +1,19 @@
 import { array_extract_at } from "std/array"
 
 // Output
-// Value at -5: "" (4) [zero one two three]
-// Value at -4: "zero" (4) [zero one two three]
-// Value at -3: "one" (4) [zero one two three]
-// Value at -2: "two" (4) [zero one two three]
-// Value at -1: "three" (4) [zero one two three]
 // Value at 0: "zero" (3) [one two three]
 // Value at 1: "one" (3) [zero two three]
 // Value at 2: "two" (3) [zero one three]
 // Value at 3: "three" (3) [zero one two]
-// Value at 4: "" (4) [zero one two three]
 
-fun test_extract(data: [Text], index: Num): Null {
-    let value = array_extract_at(data, index)
+fun test_extract(data: [Text], index: Num): Null? {
+    let value = array_extract_at(data, index)?
     echo "Value at {index}: \"{value}\" ({len(data)}) [{data}]"
 }
 
 main {
     let numbers = ["zero", "one", "two", "three"]
-    for index in -5..=4 {
-        test_extract(numbers, index)
+    for index in 0..4 {
+        test_extract(numbers, index)?
     }
 }

src/tests/stdlib/date_posix.ab

@@ -2,4 +2,4 @@ import * from "std/date"
 
 main {
 	if trust date_posix("", "@1234000000", true) == "2009-02-07T09:46:40UTC": echo "Succeeded"
-}
+}

src/tests/stdlib/text_replace_regex_basic.ab

@@ -7,6 +7,6 @@ import * from "std/text"
 
 main {
     echo replace_regex("abc123def", "\([0-9][0-9]*\)", "[\1]")
-    echo replace_regex("aeon aeons eon eons", "\beon\b", "###")
+    echo replace_regex("aeon aeons eon eons", " eon ", " ### ")
     echo replace_regex("/path/to/file.txt", "/", "#")
 }

src/tests/stdlib/text_replace_regex_ext.ab

@@ -6,6 +6,9 @@ import * from "std/text"
 // #path#to#file.txt
 
 main {
+    $ re='Copyright.+Free Software Foundation'; [[ \$(sed --version 2>/dev/null) =~ \$re ]] $ failed {
+        echo "Succeeded"
+    }
     // This will fail on any system where sed does not support extended
     // regex syntax, via "-r" on GNU sed and "-E" on all other versions.
     echo replace_regex("abc123def", "([0-9]+)", "[\1]", true)