Skip to content

Commit e4e9b7b

Browse files
committed
cpufreq/amd-pstate: Drop Kconfig option for dynamic EPP
There are some performance issues being identified by dynamic EPP and we don't want to have distributions turning it on by default exposing them to users at this time. Drop the kconfig option, and require an explicit opt in from kernel command line or runtime sysfs option to turn it on. Reported-by: Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de> Closes: https://lore.kernel.org/linux-pm/14a87c99-785c-4b16-bfce-35ecbf053448@freenet.de/ Reported-by: Stuart Meckle <stuartmeckle@gmail.com> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221473 Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com> Link: https://lore.kernel.org/r/20260512221947.1652988-1-mario.limonciello@amd.com (fix sysfs file path) Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
1 parent f9f1683 commit e4e9b7b

3 files changed

Lines changed: 5 additions & 22 deletions

File tree

Documentation/admin-guide/pm/amd-pstate.rst

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,9 @@ Dynamic energy performance profile
358358
The amd-pstate driver supports dynamically selecting the energy performance
359359
profile based on whether the machine is running on AC or DC power.
360360

361-
Whether this behavior is enabled by default depends on the kernel
362-
config option `CONFIG_X86_AMD_PSTATE_DYNAMIC_EPP`. This behavior can also be overridden
363-
at runtime by the sysfs file ``/sys/devices/system/cpu/cpufreq/policyX/dynamic_epp``.
361+
Whether this behavior is enabled by default depends on the kernel command line option
362+
``amd_dynamic_epp`` is set. This behavior can also be overridden
363+
at runtime by the sysfs file ``/sys/devices/system/cpu/amd_pstate/dynamic_epp``.
364364

365365
When set to enabled, the driver will select a different energy performance
366366
profile when the machine is running on battery or AC power. The driver will
@@ -485,9 +485,8 @@ kernel parameter ``amd_prefcore=disable``.
485485
``amd_dynamic_epp``
486486

487487
When AMD pstate is in auto mode, dynamic EPP will control whether the kernel
488-
autonomously changes the EPP mode. The default is configured by
489-
``CONFIG_X86_AMD_PSTATE_DYNAMIC_EPP`` but can be explicitly enabled with
490-
``amd_dynamic_epp=enable`` or disabled with ``amd_dynamic_epp=disable``.
488+
autonomously changes the EPP mode. The default is disabled. It can be enabled
489+
with the kernel parameter ``amd_dynamic_epp=enable``.
491490

492491
User Space Interface in ``sysfs`` - General
493492
===========================================

drivers/cpufreq/Kconfig.x86

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -70,18 +70,6 @@ config X86_AMD_PSTATE_DEFAULT_MODE
7070
For details, take a look at:
7171
<file:Documentation/admin-guide/pm/amd-pstate.rst>.
7272

73-
config X86_AMD_PSTATE_DYNAMIC_EPP
74-
bool "AMD Processor P-State dynamic EPP support"
75-
depends on X86_AMD_PSTATE
76-
default n
77-
help
78-
Allow the kernel to dynamically change the energy performance
79-
value from events like ACPI platform profile and AC adapter plug
80-
events.
81-
82-
This feature can also be changed at runtime, this configuration
83-
option only sets the kernel default value behavior.
84-
8573
config X86_AMD_PSTATE_UT
8674
tristate "selftest for AMD Processor P-State driver"
8775
depends on X86 && ACPI_PROCESSOR

drivers/cpufreq/amd-pstate.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,7 @@ static struct cpufreq_driver amd_pstate_driver;
8787
static struct cpufreq_driver amd_pstate_epp_driver;
8888
static int cppc_state = AMD_PSTATE_UNDEFINED;
8989
static bool amd_pstate_prefcore = true;
90-
#ifdef CONFIG_X86_AMD_PSTATE_DYNAMIC_EPP
91-
static bool dynamic_epp = CONFIG_X86_AMD_PSTATE_DYNAMIC_EPP;
92-
#else
9390
static bool dynamic_epp;
94-
#endif
9591
static struct quirk_entry *quirks;
9692

9793
/*

0 commit comments

Comments
 (0)