Skip to content

Commit cdae65f

Browse files
qsnkuba-moo
authored andcommitted
tls: remove tls_toe and the related driver
The tls_toe feature and its single user (chelsio chtls) have been unmaintained for multiple years. It also hooks into the core of the TCP implementation, and bypasses most of the networking stack. Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://patch.msgid.link/1f30e73275c07bf879f547589872d0916025a52e.1781165969.git.sd@queasysnail.net Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent f48cd5b commit cdae65f

22 files changed

Lines changed: 4 additions & 6358 deletions

File tree

Documentation/networking/tls-offload.rst

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Layer Protocol (ULP) and install the cryptographic connection state.
1313
For details regarding the user-facing interface refer to the TLS
1414
documentation in :ref:`Documentation/networking/tls.rst <kernel_tls>`.
1515

16-
``ktls`` can operate in three modes:
16+
``ktls`` can operate in two modes:
1717

1818
* Software crypto mode (``TLS_SW``) - CPU handles the cryptography.
1919
In most basic cases only crypto operations synchronous with the CPU
@@ -26,11 +26,6 @@ documentation in :ref:`Documentation/networking/tls.rst <kernel_tls>`.
2626
This mode integrates best with the kernel stack and is described in detail
2727
in the remaining part of this document
2828
(``ethtool`` flags ``tls-hw-tx-offload`` and ``tls-hw-rx-offload``).
29-
* Full TCP NIC offload mode (``TLS_HW_RECORD``) - mode of operation where
30-
NIC driver and firmware replace the kernel networking stack
31-
with its own TCP handling, it is not usable in production environments
32-
making use of the Linux networking stack for example any firewalling
33-
abilities or QoS and packet scheduling (``ethtool`` flag ``tls-hw-record``).
3429

3530
The operation mode is selected automatically based on device configuration,
3631
offload opt-in or opt-out on per-connection basis is not currently supported.

arch/s390/configs/debug_defconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ CONFIG_UNIX=y
125125
CONFIG_UNIX_DIAG=m
126126
CONFIG_TLS=m
127127
CONFIG_TLS_DEVICE=y
128-
CONFIG_TLS_TOE=y
129128
CONFIG_XFRM_USER=m
130129
CONFIG_NET_KEY=m
131130
CONFIG_SMC=m

arch/s390/configs/defconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ CONFIG_UNIX=y
116116
CONFIG_UNIX_DIAG=m
117117
CONFIG_TLS=m
118118
CONFIG_TLS_DEVICE=y
119-
CONFIG_TLS_TOE=y
120119
CONFIG_XFRM_USER=m
121120
CONFIG_NET_KEY=m
122121
CONFIG_SMC=m

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6795,8 +6795,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
67956795
NETIF_F_TSO | NETIF_F_TSO6;
67966796

67976797
netdev->hw_features |= NETIF_F_GSO_UDP_TUNNEL |
6798-
NETIF_F_GSO_UDP_TUNNEL_CSUM |
6799-
NETIF_F_HW_TLS_RECORD;
6798+
NETIF_F_GSO_UDP_TUNNEL_CSUM;
68006799

68016800
if (adapter->rawf_cnt)
68026801
netdev->udp_tunnel_nic_info = &cxgb_udp_tunnels;

drivers/net/ethernet/chelsio/inline_crypto/Kconfig

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,6 @@ config CHELSIO_INLINE_CRYPTO
1313

1414
if CHELSIO_INLINE_CRYPTO
1515

16-
config CRYPTO_DEV_CHELSIO_TLS
17-
tristate "Chelsio Crypto Inline TLS Driver"
18-
depends on CHELSIO_T4
19-
depends on TLS
20-
depends on TLS_TOE
21-
help
22-
Support Chelsio Inline TLS with Chelsio crypto accelerator.
23-
Enable inline TLS support for Tx and Rx.
24-
25-
To compile this driver as a module, choose M here: the module
26-
will be called chtls.
27-
2816
config CHELSIO_IPSEC_INLINE
2917
tristate "Chelsio IPSec XFRM Tx crypto offload"
3018
depends on CHELSIO_T4
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
# SPDX-License-Identifier: GPL-2.0-only
2-
obj-$(CONFIG_CRYPTO_DEV_CHELSIO_TLS) += chtls/
32
obj-$(CONFIG_CHELSIO_IPSEC_INLINE) += ch_ipsec/
43
obj-$(CONFIG_CHELSIO_TLS_DEVICE) += ch_ktls/

drivers/net/ethernet/chelsio/inline_crypto/chtls/Makefile

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)