Skip to content

Commit 8fe89ef

Browse files
bentissJiri Kosina
authored andcommitted
HID: multitouch: enable the Surface 3 Type Cover to report multitouch data
There is no reasons to filter out keyboard and consumer control collections in hid-multitouch. With the previous hid-input fix, there is now a full support of the Type Cover and we can remove all specific bits from hid-core and hid-microsoft. hid-multitouch will automatically set HID_QUIRK_NO_INIT_REPORTS so we can also remove it from the list of ushbid quirks. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent 72d1945 commit 8fe89ef

5 files changed

Lines changed: 3 additions & 7 deletions

File tree

drivers/hid/hid-core.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,6 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned type)
728728
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 ||
729729
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
730730
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP ||
731-
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
732731
hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
733732
hid->group == HID_GROUP_MULTITOUCH)
734733
hid->group = HID_GROUP_GENERIC;
@@ -1984,7 +1983,6 @@ static const struct hid_device_id hid_have_special_driver[] = {
19841983
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) },
19851984
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
19861985
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP) },
1987-
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) },
19881986
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_7K) },
19891987
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_600) },
19901988
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_3KV1) },

drivers/hid/hid-ids.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,6 @@
719719
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 0x07e2
720720
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
721721
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP 0x07e9
722-
#define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de
723722
#define USB_DEVICE_ID_MS_POWER_COVER 0x07da
724723

725724
#define USB_VENDOR_ID_MOJO 0x8282

drivers/hid/hid-microsoft.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,8 +282,6 @@ static const struct hid_device_id ms_devices[] = {
282282
.driver_data = MS_HIDINPUT },
283283
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP),
284284
.driver_data = MS_HIDINPUT },
285-
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3),
286-
.driver_data = MS_HIDINPUT },
287285
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER),
288286
.driver_data = MS_HIDINPUT },
289287
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_COMFORT_KEYBOARD),

drivers/hid/hid-multitouch.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,9 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
842842
if (!td->mtclass.export_all_inputs &&
843843
field->application != HID_DG_TOUCHSCREEN &&
844844
field->application != HID_DG_PEN &&
845-
field->application != HID_DG_TOUCHPAD)
845+
field->application != HID_DG_TOUCHPAD &&
846+
field->application != HID_GD_KEYBOARD &&
847+
field->application != HID_CP_CONSUMER_CONTROL)
846848
return -1;
847849

848850
/*

drivers/hid/usbhid/hid-quirks.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ static const struct hid_blacklist {
102102
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2, HID_QUIRK_NO_INIT_REPORTS },
103103
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
104104
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP, HID_QUIRK_NO_INIT_REPORTS },
105-
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS },
106105
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
107106
{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS },
108107
{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, HID_QUIRK_NO_INIT_REPORTS },

0 commit comments

Comments
 (0)