Skip to content

Commit 2892054

Browse files
geertulinusw
authored andcommitted
pinctrl: ingenic: Fix type in .pin_config_group_get() callback
On 64-bit platforms, "unsigned long" is 64-bit. Hence checking if all "unsigned long" configuration values are equal should be done using an "unsigned long" temporary. While Ingenic is a 32-bit platform, it is still better to use the correct type, to serve as an example. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Paul Cercueil <paul@crapouillou.net> Signed-off-by: Linus Walleij <linusw@kernel.org>
1 parent 34460ff commit 2892054

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/pinctrl/pinctrl-ingenic.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4334,7 +4334,8 @@ static int ingenic_pinconf_group_get(struct pinctrl_dev *pctldev,
43344334
unsigned int group, unsigned long *config)
43354335
{
43364336
const unsigned int *pins;
4337-
unsigned int i, npins, old = 0;
4337+
unsigned int i, npins;
4338+
unsigned long old = 0;
43384339
int ret;
43394340

43404341
ret = pinctrl_generic_get_group_pins(pctldev, group, &pins, &npins);

0 commit comments

Comments
 (0)