Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Valkey in CI. #187

Closed
wants to merge 3 commits into from

Conversation

nihohit
Copy link

@nihohit nihohit commented Sep 7, 2024

This refactors the CI pipeline to not use a cartesian product of Rust & DB version, and instead of test all Rust versions against a single DB version, and all DB versions against stable Rust, since the two are orthogonal.

This allows us to add more DB types and versions and only add 1 CI action per version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This refactors the CI pipeline to not use a cartesian product of Rust & DB version, and instead of test all Rust versions against a single DB version, and all DB versions against stable Rust, since the two are orthogonal.

This allows us to add more DB types and versions and only add 1 CI action per version.
@nihohit
Copy link
Author

nihohit commented Sep 11, 2024

@barshaul rebased over the lint fix.

Comment on lines 44 to 60
{
rust: beta,
db-org: redis,
db-name: redis,
db-version: 7.2.4
},
{
rust: nightly,
db-org: redis,
db-name: redis,
db-version: 7.2.4
},
{
rust: 1.65.0,
db-org: redis,
db-name: redis,
db-version: 7.2.4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!
Can you change the default engine to valkey 7.2.4?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failed because there's no valkey 7.2.4 in that path. returned to 7.2.6

@nihohit nihohit closed this Sep 28, 2024
@nihohit nihohit deleted the smaller-ci-upstream branch September 28, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants