hdl.ast: raise a sensible error for xxx in Value

Author: wanda-phi

amaranth/hdl/ast.py

@@ -377,6 +377,9 @@ def __getitem__(self, key):
         else:
             raise TypeError(f"Cannot index value with {key!r}")
 
+    def __contains__(self, other):
+        raise TypeError("Cannot use 'in' with an Amaranth value")
+
     def as_unsigned(self):
         """Conversion to unsigned.
 

tests/test_hdl_ast.py

@@ -750,6 +750,11 @@ def test_abs(self):
         """)
         self.assertEqual(abs(s).shape(), unsigned(4))
 
+    def test_contains(self):
+        with self.assertRaisesRegex(TypeError,
+                r"^Cannot use 'in' with an Amaranth value$"):
+            1 in Signal(3)
+
 
 class SliceTestCase(FHDLTestCase):
     def test_shape(self):