WEB-11368: Skip literals so that HiveUDAF percentile_approx can operate correctly #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this DOES fail a couple of tests, and I'm not 100% sure I'm rewriting correctly (although I don't see how my changes to the Rewriter cause failures in tests that should not be subject to rewrite because there's only one distinct....) |
|
FWIW, the two tests that fail with this change also fail without it..... |
|
backporting apache/spark/apache#15668 leads to a much better place -- the resulting query loses the unnecessary columns for the aggregate children (arguments) which were literals, because that code extracts the literals earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markhamstra don't know if it's worth pursuing this -- depends on if spark2.1 is ready to go soon and if this is a bug that customers have run into.
Also, should run tests and make sure I haven't broken anything, but it does at least pass a (new) test I added to sparky for this issue.