net: eth: altera: fix phy-handle not find issue #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function phylink_of_phy_connect() returns 0 in case of success. So, if the phy-handle attribute was found, it will return 0, but phydev will still contain the value NULL, and it will enter the condition if(!phydev) and return an error even in the successful case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The function phylink_of_phy_connect() returns 0 in case of success.
So, if the phy-handle attribute was found, it will return 0, but phydev will still contain the value NULL, and it will enter the condition if(!phydev) and return an error even in the successful case.
Impact Analysis:
What is the scope of the change and the purpose of the change?
It will return the same value as phylink_of_phy_connect() in case of success, the value 0. So, there is no need to check the condition if(!phydev).