Skip to content

Commit 512a3b0

Browse files
author
Vince Bridgers
committed
FogBugz #284801: Add explicit RMII case to stmmac initialization
This patch adds an explicit case for RMII configuration on Cyclone 5 and Arria 5 so it's obvious this case is nonfunctional on those chips. Signed-off-by: Vince Bridgers <vbridger@opensource.altera.com>
1 parent 5229789 commit 512a3b0

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

arch/arm/mach-socfpga/socfpga.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,12 @@ static int stmmac_init_c5a5(struct platform_device *pdev)
284284
case PHY_INTERFACE_MODE_SGMII:
285285
val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_GMII_MII;
286286
break;
287+
/*
288+
* RMII case is broken on Cyclone 5 and Arria 5.
289+
* Have the case fall through to failure explicitly
290+
* for documentation and debugging purposes.
291+
*/
292+
case PHY_INTERFACE_MODE_RMII:
287293
default:
288294
pr_err("%s bad phy mode %d", __func__, phymode);
289295
return -EINVAL;

0 commit comments

Comments
 (0)