Skip to content

Commit 391e982

Browse files
Alexey Dobriyanmcgrof
authored andcommitted
module: fix [e_shstrndx].sh_size=0 OOB access
It is trivial to craft a module to trigger OOB access in this line: if (info->secstrings[strhdr->sh_size - 1] != '\0') { BUG: unable to handle page fault for address: ffffc90000aa0fff PGD 100000067 P4D 100000067 PUD 100066067 PMD 10436f067 PTE 0 Oops: 0000 [#1] PREEMPT SMP PTI CPU: 7 PID: 1215 Comm: insmod Not tainted 5.18.0-rc5-00007-g9bf578647087-dirty #10 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-4.fc34 04/01/2014 RIP: 0010:load_module+0x19b/0x2391 Fixes: ec2a295 ("module: harden ELF info handling") Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> [rebased patch onto modules-next] Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
1 parent 99bd995 commit 391e982

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

kernel/module/main.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1726,6 +1726,10 @@ static int elf_validity_check(struct load_info *info)
17261726
* strings in the section safe.
17271727
*/
17281728
info->secstrings = (void *)info->hdr + strhdr->sh_offset;
1729+
if (strhdr->sh_size == 0) {
1730+
pr_err("empty section name table\n");
1731+
goto no_exec;
1732+
}
17291733
if (info->secstrings[strhdr->sh_size - 1] != '\0') {
17301734
pr_err("ELF Spec violation: section name table isn't null terminated\n");
17311735
goto no_exec;

0 commit comments

Comments
 (0)