add support for windows msi format #2910

imolorhe · 2025-10-11T02:14:31Z

Fixes

#2882

Checks

Ran yarn test-build
Updated relevant documentations
Updated matching config options in altair-static

Changes proposed in this pull request:

Summary by Sourcery

New Features:

Add MSI target for Windows builds supporting x64 and arm64 architectures

Summary by CodeRabbit

New Features
- Added Windows installers in both NSIS and MSI formats for x64 systems.
- Improved installation flexibility with multiple installer options.
- No changes to application functionality or user workflows.

sourcery-ai · 2025-10-11T02:14:37Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updated the Electron build configuration to add MSI installer support for Windows alongside existing NSIS targets, covering both x64 and arm64 architectures.

File-Level Changes

Change	Details	Files
Extended Windows build targets to include MSI format	Introduced a `target` section under the `win` configuration Added NSIS target for x64 and arm64 Added MSI target for x64 and arm64	`packages/altair-electron/electron-builder.yml`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist · 2025-10-11T02:14:42Z

Summary of Changes

Hello @imolorhe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Windows distribution capabilities by integrating support for MSI installers. This change provides an additional, standard installation method for Windows users, complementing the existing NSIS installer. The core modification involves updating the Electron build configuration to generate MSI packages, ensuring broader compatibility across both 64-bit and ARM-based Windows systems.

Highlights

Windows MSI Support: This pull request introduces support for building Windows MSI (Microsoft Installer) packages for the application.
Multi-Architecture Support: The newly added MSI build target will generate packages for both x64 and arm64 architectures, expanding compatibility.
Build Configuration Update: The electron-builder.yml file has been updated to include the MSI target configuration alongside the existing NSIS target.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2025-10-11T02:14:46Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Added Windows installer targets (nsis and msi) for x64 to the win section in packages/altair-electron/electron-builder.yml. No existing targets were removed and other configuration remains unchanged.

Changes

Cohort / File(s)	Change Summary
Build config — Windows targets `packages/altair-electron/electron-builder.yml`	Added `win` installer targets: `nsis` and `msi` for `x64`. No deletions; other settings unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit nudges build logs bright,
“NSIS and MSI take flight!”
x64 hops through the gate,
Installers lined up, feeling great.
Carrots packed — release tonight! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly and accurately describes the primary change of the pull request by stating that support for the Windows MSI format is being added and clearly conveys the main feature without extraneous detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch imolorhe/support-windows-msi

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 613ddc2 and cbb2926.

📒 Files selected for processing (1)

packages/altair-electron/electron-builder.yml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/altair-electron/electron-builder.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)

GitHub Check: sites / Deploy Login Redirect / Deploy Login Redirect
GitHub Check: sites / Deploy Sandbox / Deploy Iframe Sandbox
GitHub Check: sites / Deploy Docs / Deploy Documentation
GitHub Check: sites / Deploy Web App / Deploy Web App
GitHub Check: tests / e2e-test (macos-latest)
GitHub Check: tests / e2e-test (ubuntu-latest)
GitHub Check: tauri / tauri (macos-latest, --target x86_64-apple-darwin)
GitHub Check: tauri / tauri (macos-latest, --target aarch64-apple-darwin)
GitHub Check: tauri / tauri (ubuntu-22.04)
GitHub Check: tauri / tauri (windows-latest)
GitHub Check: tests / test (ubuntu-latest)
GitHub Check: docker / docker
GitHub Check: tests / api-e2e-test
GitHub Check: tests / test (macos-latest)
GitHub Check: electron / electron (ubuntu-latest)
GitHub Check: electron / electron (windows-latest)
GitHub Check: electron / electron (macos-latest)
GitHub Check: Sourcery review
GitHub Check: build_and_preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gemini-code-assist

Code Review

This pull request adds support for generating MSI installers for Windows, for both x64 and arm64 architectures. The configuration change in electron-builder.yml is correct. I've suggested a small simplification to avoid duplicating the architecture list, which will improve the maintainability of the configuration file.

gemini-code-assist · 2025-10-11T02:15:32Z

packages/altair-electron/electron-builder.yml

+  target:
+    - target: nsis
+      arch:
+        - x64
+        - arm64
+    - target: msi
+      arch:
+        - x64
+        - arm64


The list of architectures is duplicated for both nsis and msi targets. You can define the architectures once at the win level to apply to all Windows targets. This will make the configuration more concise and easier to maintain.¹

target: - nsis - msi arch: - x64 - arm64

Rules References

Footnotes

Adhering to the Don't Repeat Yourself (DRY) principle helps in reducing repetition of information, which is beneficial for maintenance. In this case, defining the architectures once avoids potential inconsistencies if they need to be updated in the future. ↩

github-actions · 2025-10-11T02:18:03Z

Visit the preview URL for this PR (updated for commit cbb2926):

https://altair-gql--pr2910-imolorhe-support-win-ynnx9m48.web.app

_{(expires Sat, 18 Oct 2025 07:25:01 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 02d6323d75a99e532a38922862e269d63351a6cf}

imolorhe · 2025-10-11T06:58:13Z

Related. Looks like signing has to be done electron-userland/electron-builder#7248

add support for windows msi format

613ddc2

sourcery-ai bot approved these changes Oct 11, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 11, 2025

View reviewed changes

schema

cbb2926

Uh oh!

Uh oh!

add support for windows msi format #2910

Are you sure you want to change the base?

add support for windows msi format #2910

Uh oh!

Conversation

imolorhe commented Oct 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes

Checks

Changes proposed in this pull request:

Summary by Sourcery

Summary by CodeRabbit

Uh oh!

sourcery-ai bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot commented Oct 11, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 11, 2025

Choose a reason for hiding this comment

Rules References

Footnotes

Uh oh!

github-actions bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

imolorhe commented Oct 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

imolorhe commented Oct 11, 2025 •

edited by coderabbitai bot

Loading

sourcery-ai bot commented Oct 11, 2025 •

edited

Loading

coderabbitai bot commented Oct 11, 2025 •

edited

Loading

github-actions bot commented Oct 11, 2025 •

edited

Loading