Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards and readability in dark-mode #502

Closed
3 tasks done
veedata opened this issue Dec 12, 2021 · 1 comment · Fixed by #509
Closed
3 tasks done

Cards and readability in dark-mode #502

veedata opened this issue Dec 12, 2021 · 1 comment · Fixed by #509

Comments

@veedata
Copy link
Contributor

veedata commented Dec 12, 2021

Acknowledge the following

  • I carefully read and followed the Getting Started guide.
  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • The issue I am raising is a potential bug in al-folio and not just a usage question.
    [For usage questions, please post in the Discussions instead of raising an issue.]

Describe the bug
Cards have a white background color in dark-mode, which defeats the purpose of dark mode. Additionally, as described in #183, code readability issues still exist but that issue has been closed.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on dark mode by setting enable_darkmode: true in _config.yml file
  2. Run the site bundle exec jekyll serve
  3. Click on the dark/light switch button on the top right corner to turn on dark mode

Expected behavior
Cards should have a darker shade (preferably bg-dark from bootstrap) and code-blocks should be more readable

Screenshots
Code block:
image

Projects:
image

System (please complete the following information):

  • OS: Windows 11
  • Browser: Edge 96.0.1054.53
  • Jekyll 4.2.1
  • Ruby 3.0.2p107
@stale
Copy link

stale bot commented Feb 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants