Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord embeds have strange spacing when linking pages #493

Closed
3 tasks done
smashmath opened this issue Dec 6, 2021 · 2 comments · Fixed by #481
Closed
3 tasks done

Discord embeds have strange spacing when linking pages #493

smashmath opened this issue Dec 6, 2021 · 2 comments · Fixed by #481
Labels

Comments

@smashmath
Copy link

smashmath commented Dec 6, 2021

Acknowledge the following

  • I carefully read and followed the Getting Started guide.
  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • The issue I am raising is a potential bug in al-folio and not just a usage question.
    [For usage questions, please post in the Discussions instead of raising an issue.]

Describe the bug
When sharing links to sites using the theme (other than the about page), there is some strange spacing between the site name and page title. Example:

To Reproduce
Steps to reproduce the behavior:

  1. Go to discord (desktop client, browser, app, it doesn't matter)
  2. Paste any link to a page using the theme (other than the about page) into a message

Expected behavior
To look like it did before without a giant space between the site name and page title.

Screenshots
This is how embeds used to look vs how they look now. I noticed this first because I had edited the second message which had a link in it today after updating the theme.
(Despite being Nov 26, it had been several months since I had updated to the most current version of al-folio). This bug must have cropped up sometime in the last few months.

System (please complete the following information):
This stuff is kinda irrelevant since it's on the discord client, browser instances of discord, and on the discord mobile app rather than the site itself, but whatever.

  • OS: Windows 10
  • Browser (and its version) Chrome 96.0.4664.45
  • Jekyll version 4.2.1
  • Ruby version 3.0

Additional context
This is a fresh install and not unique to my blog.

@smashmath smashmath added the bug label Dec 6, 2021
@jmrplens
Copy link
Contributor

jmrplens commented Dec 6, 2021

Solved with my PR #481

In the meantime, you can change the title block in _includes/head.html to this:

<title>
{% if site.title == "blank" %}
{% capture title %}{{ site.first_name }} {{ site.middle_name }} {{ site.last_name }}{% endcapture %}
{% else %}
{% capture title %}{{ site.title }}{% endcapture %}
{% endif %}
{% if page.title != "blank" and page.url != "/" %}
{{ title }} | {{ page.title }}
{% else %}
{{ title }}
{% endif %}
</title>

@smashmath
Copy link
Author

@jmrplens This fixed it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants