Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom favicon if needed #407

Closed
pourmand1376 opened this issue Sep 25, 2021 · 0 comments · Fixed by #386
Closed

Add custom favicon if needed #407

pourmand1376 opened this issue Sep 25, 2021 · 0 comments · Fixed by #386

Comments

@pourmand1376
Copy link
Collaborator

pourmand1376 commented Sep 25, 2021

Hi, As I needed to customize my favicon and apply an icon, I thought this might be helpful for others as well. So why not create a pull request? #386

Here's how I think It should work. If the client sets use_custom_favicon to true, then he can provide a path instead of emoji in the icon. Otherwise, It works with emoji. So backward compatibility wouldn't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant