Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asymmetrical padding in figures produced via bootstrap grid + figure.liquid #2207

Closed
2 tasks done
renauddetry opened this issue Feb 16, 2024 · 3 comments
Closed
2 tasks done

Comments

@renauddetry
Copy link

renauddetry commented Feb 16, 2024

Have you checked that your issue isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • Yes, I have checked that this issue isn't already filed.

Bug description

asymmetrical padding in figures produced via bootstrap grid + figure.liquid

How to reproduce the bug

  1. Navigate to https://renauddetry.github.io/al-folio/projects/2_project/
  2. You'll notice vertical and horizontal asymmetries in the space that surrounds images (also illustrated in screenshots below).
  3. Paddings change non proportionally when shrinking the viewport. See screenshots below for illustration.

The only functional change of the fork above is the addition of the following styling, to make the space around images easier to see:

.row {
  border: 1px solid red;
}

.mt-3 {
  border: 1px solid green;
}

The following screenshots illustrate the problem on a wide window, narrower window, and even narrower window.

Wide window

1-wide-window

Narrower window

2-narrower-window

Even narrower window

3-even-narrower-window

It's surprising that Bootstrap produces those flaky layouts. The following hack fixes the padding issues discussed above (but probably introduce new problems elsewhere):

  • Remove the Bootstrap grid <div>'s around figure.liquid calls
  • wrap figure.liquid with a div of class figure-r
  • import the following styles after other imports:
figure {
    all: initial;
}

.figure-r {
    margin-bottom: 1rem;
}

.profile {
    margin-bottom: 1rem;
}

Error messages and logs

See screenshots above

What operating system are you using?

Mac

Where are you seeing the problem on?

Deployed site

More info

The problem seems to be browser-agnostic

Copy link

stale bot commented Apr 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 21, 2024
Copy link

stale bot commented Jun 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 23, 2024
Copy link

stale bot commented Aug 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 27, 2024
@stale stale bot closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants