Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal project card is not "horizontal" when including github icon #1255

Closed
3 tasks done
Demi-wlw opened this issue Mar 11, 2023 · 2 comments
Closed
3 tasks done

Comments

@Demi-wlw
Copy link

Demi-wlw commented Mar 11, 2023

Acknowledge the following

  • I carefully read and followed the Getting Started guide.
  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • The issue I am raising is a potential bug in al-folio and not just a usage question.
    [For usage questions, please post in the Discussions instead of raising an issue.]

Describe the bug
When using the horizontal project card, if I also specify the github link in num_project.md, the card will no longer be horizontal.

To Reproduce
Steps to reproduce the behavior:

  1. Go to _pages/projects.md: horizontal: true; change <div class="row row-cols-2"> to <div class="row row-cols-1"> at lines 23 and 44. (This is for my case but I think it doesn't matter)
  2. Go to _projects/5_project.md): add github: link here

Expected behavior
The card is horizontal with github icon.

Screenshots
截屏2023-03-11 20 56 37

System (please complete the following information):

  • OS: Ventura 13.2.1
  • Browser : Chrome Version 110.0.5481.177
  • Jekyll version: 4.3.2
  • Ruby version: 3.2.1
@Demi-wlw Demi-wlw added the bug label Mar 11, 2023
@george-gca
Copy link
Collaborator

When you change <div class="row row-cols-2"> to <div class="row row-cols-1"> you are explicitly saying to use only one column. That's why the cards appear one per row.

As for the layout inside the card, I agree that it is not right.

@stale
Copy link

stale bot commented Jun 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 24, 2023
@stale stale bot closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants