Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate branches not hit #247

Open
jamesadarich opened this issue Dec 23, 2016 · 3 comments
Open

Investigate branches not hit #247

jamesadarich opened this issue Dec 23, 2016 · 3 comments

Comments

@jamesadarich
Copy link
Member

NYC is reporting some branches not being hit on errors around a semicolon after a super call.

@jamesadarich jamesadarich added this to the 1.1.0 milestone Dec 25, 2016
@jamesadarich jamesadarich modified the milestones: 1.1.0, 1.2.0, 1.3.0, 1.4.0 Jan 3, 2017
@jamesadarich
Copy link
Member Author

looks like an issue with TypeScript since 2.1 emitting the following code on extending classes

var _this = _super.call(this) || this;

until this is resolved (hopefully in this issue) we'll need to actually test this functionality so I've added test/unit-tests/errors/temporary-branch-fix.spec.ts to do this until this is actually solved

@jamesadarich jamesadarich modified the milestones: 1.4.0, 1.6.0 May 10, 2017
@pathurs
Copy link
Contributor

pathurs commented Jul 20, 2018

@jamesadarich Is this still an issue?

@jamesadarich
Copy link
Member Author

@pathurs I've just checked and yes it is still a thing. I think probably the best solution is to run these tests directly via ts-node I'd guess because the missing branches are due to the compiled javascript which is something we shouldn't really be worried about.

@jamesadarich jamesadarich removed this from the 2.2.0 milestone Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants