Python2-3 compatibility fixes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for the PR, and sorry for the delay. Can you confirm that the code now works properly on both Python 2 and Python 3? Thanks. |
|
No worries!! With my changes, I can run the shell script using either python 2.7.16 or python 3.7.3. Any intermediate versions of python should also work. |
|
@alphapapa Can this be merged? |
alphapapa
force-pushed
the
samspills/python2-3-compatible
branch
from
13a8761
to
fbadc75
Compare
Closes alphapapa#31. Thanks to Sam Pillsworth (@samspills).
alphapapa
force-pushed
the
samspills/python2-3-compatible
branch
from
fbadc75
to
23a1336
Compare
|
Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two compatibility issues with python3 in the
urlencodefunction.print_functionfrom future, and useprint()quoteinstead ofurllib.quote