Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to actually take advantage of passed categories via message regex. #790

Open
1 of 3 tasks
dsayling opened this issue Feb 2, 2024 · 0 comments
Open
1 of 3 tasks

Comments

@dsayling
Copy link

dsayling commented Feb 2, 2024

As a user of the categories.json, I want to be able to display "Passed" categories mapped from the categories.json using the messageRegex, so that I can show different "Passed" categories by Name in the UI.

I'm submitting a ...

  • bug report
  • feature request
  • support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

In pytest_runtest_makereport, the default value of status_details is None, and when test_result.status == Status.PASSED, it's still None.

As far as I know there's no way to actually provide a message that would enable this to work in a categories.json

[
  {
    "name": "Integration Passed",
    "messageRegex": ".*IntegrationTest.*",
    "matchedStatuses": ["passed"]
  }
]

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

A simple bit of code I would expect to work

@pytest.hookimpl(hookwrapper=True)
def pytest_runtest_makereport(item, call):
    report = (yield).get_result()
    if call.when == "call" and report.passed:
        report.longrepr = "IntegrationTest Passed"

What is the expected behavior?

That I can provide a Passed Message to allure to do stuff with the categories.json

        status_details = StatusDetails(message=report.longreprtext)

Please tell us about your environment:

  • Allure version: 2.26.0
  • Test framework: pytest@7.4.2
  • Allure adaptor: allure-pytest@2.13.2
platform darwin -- Python 3.11.3, pytest-7.4.2, pluggy-1.3.0
plugins: cov-4.1.0, mock-3.11.1, anyio-3.7.1, xdist-3.3.1, check-2.2.2, allure-pytest-2.13.2

Other information

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant