Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't enable foldhash by default #771

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

DaniPopes
Copy link
Member

Fixes #767

@DaniPopes DaniPopes merged commit a7486f4 into main Oct 13, 2024
29 checks passed
@DaniPopes DaniPopes deleted the dani/no-foldhash-default branch October 13, 2024 02:14
@hai-rise
Copy link

@DaniPopes @mattsse I did a naive dep bump for pevm today, it was consistently red with up to 35% regression.
https://github.com/risechain/pevm/pull/386/files

image

10-35% regression on a casual alloy-primitives bump is very scary, and I don't think most library users have rigid benchmarks to catch it. I'd suggest either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default hasher foldhash queries the time
3 participants