Skip to content

Commit 1b98d56

Browse files
authored
refactor: remove Signature generic (#719)
* refactor: remove Signature generic * clippy * fixes * fixes
1 parent 446b9d2 commit 1b98d56

File tree

4 files changed

+95
-140
lines changed

4 files changed

+95
-140
lines changed

crates/core/src/lib.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ pub use alloy_primitives as primitives;
1212
#[doc(no_inline)]
1313
pub use primitives::{hex, uint};
1414

15-
#[cfg(feature = "unstable-doc")]
16-
#[doc(hidden)]
17-
#[allow(unused_imports)]
18-
pub use primitives::PrivateSignature as _;
19-
2015
#[cfg(feature = "dyn-abi")]
2116
#[doc(inline)]
2217
pub use alloy_dyn_abi as dyn_abi;

crates/primitives/src/lib.rs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -49,21 +49,7 @@ mod signed;
4949
pub use signed::{BigIntConversionError, ParseSignedError, Sign, Signed};
5050

5151
mod signature;
52-
pub use signature::{to_eip155_v, Parity, SignatureError};
53-
54-
/// Only available for documentation purposes.
55-
// Without this visible (not `#[doc(hidden)]`) re-export, `rustdoc` will not generate documentation
56-
// for the `Signature` type alias below.
57-
#[cfg(feature = "unstable-doc")]
58-
pub use signature::Signature as PrivateSignature;
59-
60-
/// An ECDSA Signature, consisting of V, R, and S.
61-
#[cfg(feature = "k256")]
62-
pub type Signature = signature::Signature<k256::ecdsa::Signature>;
63-
64-
/// An ECDSA Signature, consisting of V, R, and S.
65-
#[cfg(not(feature = "k256"))]
66-
pub type Signature = signature::Signature<()>;
52+
pub use signature::{to_eip155_v, Parity, Signature, SignatureError};
6753

6854
pub mod utils;
6955
pub use utils::{eip191_hash_message, keccak256, Keccak256};

crates/primitives/src/signature/mod.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@ mod parity;
55
pub use parity::Parity;
66

77
mod sig;
8-
#[cfg(feature = "unstable-doc")]
98
pub use sig::Signature;
10-
#[cfg(not(feature = "unstable-doc"))]
11-
pub(crate) use sig::Signature;
129

1310
mod utils;
1411
pub use utils::to_eip155_v;

0 commit comments

Comments
 (0)