Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serde for eth_simulateV1 #1273

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: serde for eth_simulateV1 #1273

merged 2 commits into from
Sep 11, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Sep 10, 2024

Motivation

Updates serde for eth_simulateV1 to match JSON encoding in geth. ref ethereum/go-ethereum#27720

There's another change for BlockOverrides fields which I am not sure we should address now:

Block override fields of eth_call and debug_traceCall have had the following fields renamed

  • coinbase -> feeRecipient
  • random -> prevRandao
  • baseFee -> baseFeePerGas

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse merged commit 5354223 into main Sep 11, 2024
30 checks passed
@mattsse mattsse deleted the klkvr/fix-sim-json branch September 11, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse